Ihor Radchenko writes:
> Because I missed it.
Gotcha! (Just wanted to make sure I understand.)
> Now, added the info link.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c0a9c9ede
Thank you!
Rudy
--
"Genius is 1% inspiration and 99% perspiration."
-- Thomas Alva Edison, 1
Rudolf Adamkovič writes:
> Ihor Radchenko writes:
>
>> Thanks!
>> Applied, onto bugfix.
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3d817c52c
>
> Why not the one with the correct Info link, as per Max's excellent nitpick?
Because I missed it.
Now, added the info link.
htt
Ihor Radchenko writes:
> Thanks!
> Applied, onto bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3d817c52c
Why not the one with the correct Info link, as per Max's excellent nitpick?
Rudy
--
"Be especially critical of any statement following the word
'obviously.'"
--
Rudolf Adamkovič writes:
> Please see the attached patch, revised as follows:
>
> - no leading space in the mode line element to make it completely correct
> - a clear explanation (with a citation) to avoid pointless discussions
> - two new automated tests to avoid future regressions
> - a cleare
Max Nikulin writes:
> nitpick
>
> [...]
>
>> To make a hyperlink to Info documentation, [...]
That is a good nitpick, thank you!
Fixed in the attached patch (along with indentation).
Rudy
>From 60c86cf1991e5437084b3efb28f0866c5a50ca6b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=
On 04/03/2023 04:03, Rudolf Adamkovič wrote:
+(ert-deftest test-org-clock/mode-line ()
+ "Test mode line string ends in a space.
+
+\"Elements that are added to [the mode line] should normally end
+in a space (to ensure that consecutive 'global-mode-string'
+elements display properly)\" per Emac
Ihor Radchenko writes:
> Rudolf, I am OK with the patch, but could you please add a comment
> explaining why trailing space, so that people do not wonder in future?
Please see the attached patch, revised as follows:
- no leading space in the mode line element to make it completely correct
- a c
Max Nikulin writes:
> On 02/03/2023 21:14, Rudolf Adamkovič wrote:
>> +++ b/lisp/org-clock.el
>> @@ -728,9 +728,9 @@ If not, show simply the clocked time like 01:50."
>> 'org-mode-line-clock-overrun
>>'org-mode-line-clock)))
>>
On 02/03/2023 21:14, Rudolf Adamkovič wrote:
+++ b/lisp/org-clock.el
@@ -728,9 +728,9 @@ If not, show simply the clocked time like 01:50."
'org-mode-line-clock-overrun
'org-mode-line-clock)))
(effort-str (org-duration-fr
