Re: [PATCH] ob-python: Fix async evaluation

2023-07-13 Thread Jack Kamm
Liu Hui writes: > Thanks for pointing out the problem! I find the problem disappears > after removing the `run-python` line, and I have updated the patch > accordingly. Thank you. I applied your patch to main branch. I am curious why the previous version of your test was causing hanging -- whet

Re: [PATCH] ob-python: Fix async evaluation

2023-07-13 Thread Liu Hui
Jack Kamm 于2023年7月13日周四 05:58写道: > While your test works on its own, it seems to break subsequent tests > (the next test hangs). Thanks for pointing out the problem! I find the problem disappears after removing the `run-python` line, and I have updated the patch accordingly. From 4c552eb4eec5d84

Re: [PATCH] ob-python: Fix async evaluation

2023-07-12 Thread Jack Kamm
Liu Hui writes: > OK, I have added a test to the patch. While your test works on its own, it seems to break subsequent tests (the next test hangs). My guess is that it has something to do with the fact that most of the Python session tests share the same session, and ob-python is getting confus

Re: [PATCH] ob-python: Fix async evaluation

2023-07-12 Thread Liu Hui
Jack Kamm 于2023年7月12日周三 12:51写道: > The patch looks good, but it would be nice to include a unit test as > well -- could you update the patch to include one, Liu Hui? OK, I have added a test to the patch. From 56fd5e05bc7dc82fb825416100e75663a520 Mon Sep 17 00:00:00 2001 From: Liu Hui Date:

Re: [PATCH] ob-python: Fix async evaluation

2023-07-11 Thread Jack Kamm
Ihor Radchenko writes: > Liu Hui writes: > >> To reproduce the bug: >> >> 1. create test.org: >> ──✀── >> #+begin_src python :session "*Python 3*" :async t >> 1 >> #+end_src >> >> # Local Variables: >> # python-shell-buffer-name: "Python 3" >> # End: >> ──

Re: [PATCH] ob-python: Fix async evaluation

2023-07-11 Thread Ihor Radchenko
Liu Hui writes: > To reproduce the bug: > > 1. create test.org: > ──✀── > #+begin_src python :session "*Python 3*" :async t > 1 > #+end_src > > # Local Variables: > # python-shell-buffer-name: "Python 3" > # End: > ──✀── > > 2. emacs