Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: > I fixed the test and then applied your patches on top of that. Oh, that is so nice of you! Thanks. > I also amended if-let to become if-let*. The former is obsolete on Emacs > master. Good catch! > Applied, onto main. > https://git.savannah.gnu.org/cgit/emacs/org-mod

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: >> [I also wonder if we need exception handling around that call to >> `org-edit-src-code', when there is no "No such language mode" error >> going forward.] > > Could you please elaborate what you mean? Sorry! You can ignore this. The `org-babel-do-in-edit-buffer' macro

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: >> The test creates a `src' block with the language set to `any-language'. >> It passes with that fake language, but when I change it to something >> real, such as `c' or `fundamental', the indentation is incorrect, and >> the test fails. > > I can reproduce. > The test is

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Rudolf Adamkovič writes: > Compared to `main', I see the following test failing: > > - test-ob/demarcate-block-split-prefix-region > > Is that what you are seeing too? Yes. > [I also see "14 skipped results" due to missing dependencies, but README > says nothing about how to fix those. The "De

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: > Note that some tests are failing when I try "make test". Please make > sure that all the tests are passing. Compared to `main', I see the following test failing: - test-ob/demarcate-block-split-prefix-region Is that what you are seeing too? [I also see "14 skipped res

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Rudolf Adamkovič writes: > Subject: [PATCH 1/2] Fall back to Fundamental mode when editing code Thanks for the patch! Note that some tests are failing when I try "make test". Please make sure that all the tests are passing. > +(defun org-src-get-lang-mode-if-bound (lang &optional fallback > f

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: > Thanks for the patch! Thank you reviewing my work. > You are introducing a new behavior, so please update etc/ORG-NEWS. > Also, 16.10 Editing Source Code section of the manual needs an > update. You are right. Now done. > Maybe you can suppress the message when FALLB

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Rudolf Adamkovič writes: > I did not change `org-src-get-lang-mode' directly. Instead I wrapped > it in `org-src-get-lang-mode-if-bound' which does little more. WDYT? Thanks for the patch! You are introducing a new behavior, so please update etc/ORG-NEWS. Also, 16.10 Editing Source Code sectio

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Rudolf Adamkovič writes: > Ihor Radchenko writes: > >> Then, take your time. > > All right, I finally found some time. Ping. :) Rudy -- "Thinking is a momentary dismissal of irrelevancies." --- Richard Buckminster Fuller, 1969 Rudolf Adamkovič [he/him] http://adamkovic.org

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: > Then, take your time. All right, I finally found some time. > My specific suggestion was > 1. creating ob-graphviz.el that simply loads ob-dot I did not do this. > 2. making "graphviz" an alias to "dot" lang name for >babel Done in the attached patch 0002 (that b

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Rudolf Adamkovič writes: > I am currently super-duper busy with uni assignments. > ... Then, take your time. > ... Basically, we want the > `graphviz-dot-mode' to be enabled when editing GraphViz Dot code blocks, > while also retaining DWIM executing via Org Babel. If I understand your > advic

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: > It has been a while. > Rudolf, may I know if you are still interested in this patch? I am currently super-duper busy with uni assignments. If you can whip it out in a couple of minutes, please do. Basically, we want the `graphviz-dot-mode' to be enabled when editing Gr

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: > I would not object making "graphviz" an alias to "dot" lang name for > babel. > ... > I think that the least breaking course of action would be creating > ob-graphviz.el that simply loads ob-dot. It has been a while. Rudolf, may I know if you are still interested in this

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Rudolf Adamkovič writes: > A user of the Org Mode and Graphviz has currently 3 options: > > (1) Write `#+begin_src dot': > > - lose all benefits of the specialized major mode > - keep all benefits of Org Babel There is an option to customize `org-src-lang-modes'. > (2) Write `#+begin_sr

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Ihor Radchenko writes: > They work. Fundamental mode is usable, isn't it? As usable as any other language: no syntax highlighting, no correct indentation, no compilation and run, no code completion, etc. Instead of theorizing, let me tell you my experience, as a user of the Org Mode and Graphvi

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Rudolf Adamkovič writes: > I noticed that `dot' source blocks do not work out of the box: C-c C-c > works but C-c ' uses the Fundamental mode, even with the Graphviz MELPA > package installed. They work. Fundamental mode is usable, isn't it? In contrast, if you force using graphwiz-dot-mode from

Re: [PATCH] ob-dot: Add `graphviz-dot' language alias

Rudolf Adamkovič writes: Greetings, Org hackers! I noticed that `dot' source blocks do not work out of the box: C-c C-c works but C-c ' uses the Fundamental mode, even with the Graphviz MELPA package installed. This is because the major mode for the Dot language is `graphviz-dot' and not