Re: [PATCH] lisp/ob-scheme.el

2023-04-29 Thread Zelphir Kaltstahl
On 4/25/23 14:28, Ihor Radchenko wrote: Zelphir Kaltstahl writes: Subject: [PATCH] org-babel-expand-body:scheme: define header arg vars using define Applied, onto main, adding TINYCHANGE cookie and newline between variable definitions and body. https://git.savannah.gnu.org/cgit/emacs/org-mo

Re: [PATCH] lisp/ob-scheme.el

2023-04-25 Thread Ihor Radchenko
Zelphir Kaltstahl writes: > Subject: [PATCH] org-babel-expand-body:scheme: define header arg vars using > define Applied, onto main, adding TINYCHANGE cookie and newline between variable definitions and body. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d97ba5ba5 You are als

Re: [PATCH] lisp/ob-scheme.el

2023-03-26 Thread Ihor Radchenko
Zelphir Kaltstahl writes: >>> + "Expand :var header arguments given as VARS." >>> + (mapconcat >>> + (lambda (var) >>> + (format "(define %s %S)" (car var) (cdr var))) >> Is there any reason why you use %s for variable name? Previously it was >> formatted with escapes (using %S). > > That

Re: [PATCH] lisp/ob-scheme.el

2023-03-25 Thread Zelphir Kaltstahl
Not sure it meets all formalities. For example it is not clear to me, whether I should add the "TINYCHANGE" at the bottom of my commit message. You should, unless you have FSF copyright assignment. I am not sure what "have FSF copyright assignment" means. I would not mind assigning copyright of

Re: [PATCH] lisp/ob-scheme.el

2023-03-22 Thread Ihor Radchenko
Zelphir Kaltstahl writes: > I've created a patch, which I will attach to this e-mail. Thanks! > Not sure it meets all formalities. For example it is not clear to me, whether > I > should add the "TINYCHANGE" at the bottom of my commit message. You should, unless you have FSF copyright assign