Re: [PATCH] Prefix CL symbols in ob-lisp.el

2025-03-09 Thread Ihor Radchenko
Owen Radcliffe writes: > Not used to the workflow on mailing lists but here is a second patch to > address that issue: Thanks! Applied, onto main, adding a proper commit message and TINYCHANGE cookie (you do not seem to have copyright assignment). https://git.savannah.gnu.org/cgit/emacs/org-mode

Re: [PATCH] Prefix CL symbols in ob-lisp.el

2025-03-08 Thread Owen Radcliffe
Not used to the workflow on mailing lists but here is a second patch to address that issue: On Fri, Mar 7, 2025 at 6:01 PM Owen Radcliffe wrote: > Yes, definitely prefix the special var too, thank you. > > On Fri, Mar 7, 2025 at 13:51 Héctor Galbis Sanchis < > hectometrocuadr...@gmail.com> wrote

Re: [PATCH] Prefix CL symbols in ob-lisp.el

2025-03-07 Thread Owen Radcliffe
Yes, definitely prefix the special var too, thank you. On Fri, Mar 7, 2025 at 13:51 Héctor Galbis Sanchis < hectometrocuadr...@gmail.com> wrote: > Owen is right. If the user is using any package that doesn't 'use-package' > the "CL" package org will fail. > > I think the patch Owen provides is go

Re: [PATCH] Prefix CL symbols in ob-lisp.el

2025-03-07 Thread Héctor Galbis Sanchis
Owen is right. If the user is using any package that doesn't 'use-package' the "CL" package org will fail. I think the patch Owen provides is good. Just a little note on `org-babel-lisp-dir-fmt`. I think the symbol `*default-pathname-defaults*` should be `cl:*default-pathname-defaults*` too, since

Re: [PATCH] Prefix CL symbols in ob-lisp.el

2025-03-06 Thread Owen Radcliffe
The use of Coalton can be considered a contrived example, although important to some people, but symbols not being prefixed assumes that users are in packages that (:use :cl) and don't shadow anything important. On Thu, Mar 6, 2025 at 13:58 Ihor Radchenko wrote: > Owen Radcliffe writes: > > > H

Re: [PATCH] Prefix CL symbols in ob-lisp.el

2025-03-06 Thread Ihor Radchenko
Owen Radcliffe writes: > Here are steps to reproduce the issue I am fixing: > > 1. Start sly and load Coalton: > - M-x sly > - (asdf:load-system :coalton) > > 2. Enter the :coalton-user package, it does not use :cl > - (in-package :coalton-user) > > 3. Evaluate the following org-babel src b