Re: [PATCH] Possibility of using alternative separators in macros

2021-05-17 Thread Christian Moe
Maxim Nikulin writes: > On 17/05/2021 02:21, Christian Moe wrote: >> Maxim Nikulin writes: >>> On 03/05/2021 04:08, Christian Moe wrote: >> [snip] >>> #+MACRO: allargshack (eval (format "- /%s/ :: %s" $1 (mapconcat >>> #'identity _ ","))) >>> >>> {{{allargshack(one, two, three)}}} >>> >>> I do n

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-17 Thread Maxim Nikulin
On 17/05/2021 02:21, Christian Moe wrote: Maxim Nikulin writes: On 03/05/2021 04:08, Christian Moe wrote: [snip] #+MACRO: allargshack (eval (format "- /%s/ :: %s" $1 (mapconcat #'identity _ ","))) {{{allargshack(one, two, three)}}} I do not know if Eric can swap order of arguments of his cre

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-16 Thread Christian Moe
Maxim Nikulin writes: > On 03/05/2021 04:08, Christian Moe wrote: [snip] >> Something that would help, without adding new syntax, is >> making macro expansion smart enough to *ignore* separators when the >> macro definition contains only *one* argument anyway, as in the cases >> above. > > I thi

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-16 Thread Maxim Nikulin
On 16/05/2021 19:17, Bastien wrote: Juan Manuel Macías writes: (On the other hand, maybe better than an alternate separator, some kind of warning for unescaped commas might be more useful, as Maxim commented here: https://orgmode.org/list/s7g...@ciao.gmane.io/) Yes, probably -- feel free to

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-16 Thread Bastien
Hi Juan, Juan Manuel Macías writes: > (On the other hand, maybe better than an alternate separator, some kind of > warning for unescaped commas might be more useful, as Maxim commented > here: https://orgmode.org/list/s7g...@ciao.gmane.io/) Yes, probably -- feel free to propose a patch for this

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-15 Thread Juan Manuel Macías
Hi Bastien, Bastien writes: > I'm skeptical too, so perhaps the best thing to do is to see if you > need it or not, and if proven useful after a while, repost a patch? I totally agree. I will try these modifications for a while, if they are really useful. Anyway, as Nicolas commented in a previo

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-15 Thread Bastien
Hi Juan, Juan Manuel Macías writes: > Anyway, I admit that I have become somewhat skeptical about the > usefulness of my patch. Perhaps, as a patch, it is too premature and > perhaps it's better to leave the macros issue, for the moment, as it > is... What do you think? I'm skeptical too, so pe

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-15 Thread Juan Manuel Macías
Hi Bastien, Bastien writes: > I'll let Eric test and comment, but in the meantime, I'm just > noticing the patch breaks many tests in master. > > If Nicolas thinks this change is good and Eric validate the patch, > please prepare one with a commit message, updating the tests too. Ok, if necessa

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-15 Thread Bastien
Hi Juan, Juan Manuel Macías writes: > Here is the fixed version of the patch. I'll let Eric test and comment, but in the meantime, I'm just noticing the patch breaks many tests in master. If Nicolas thinks this change is good and Eric validate the patch, please prepare one with a commit messa

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-12 Thread Maxim Nikulin
On 03/05/2021 04:08, Christian Moe wrote: I frequently need to escape commas in macros, which is a bit of a pain and easy to forget. Maybe it is not convenient, but if unescaped comma is a real pain, you could detect it and report an error # single line may be wrapped by mailer #+MACRO: ext

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-11 Thread Juan Manuel Macías
Here is the fixed version of the patch. Best regards, Juan Manuel Eric S Fraga writes: > Could you create a new patch so I can try this easily? > > gracias, > eric >From 4aae61c3600fba136dfa101d54011c0aef9169a3 Mon Sep 17 00:00:00 2001 From: Juan Manuel Macías Date: Tue, 11 May 2021 18:41:34

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-11 Thread Juan Manuel Macías
Hello Eric, It's a typo, sorry: I forgot, when I made the patch, to add the asterisk to the `let' expression in org-element-macro-parser, therefore the `sep' variable was not recognized. The correct function is: (defun org-element-macro-parser () "Parse macro at point, if any. When at a m

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-11 Thread Eric S Fraga
Hello Juan, On Friday, 30 Apr 2021 at 13:26, Juan Manuel Macías wrote: > Hi all, > > I would like to propose (patch attached) the possibility of using an > alternate character for separate arguments in replacement macros, > following a suggestion from Nicolas Goaziou in this (closed) thread: > htt

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-02 Thread Christian Moe
I frequently need to escape commas in macros, which is a bit of a pain and easy to forget. My most frequent use case is a macro that expands in ODT export to a margin comment (like #+begin_annotation does, but without causing a line break). It takes one argument which typically consists of severa

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-02 Thread Eric S Fraga
(resent: some receiving server complained about multiple recipients blah blah so I am testing with just the org mode mailing list as the recipient; apologies for noise if you receive this twice) On Saturday, 1 May 2021 at 12:04, Nicolas Goaziou wrote: > BTW, I would like to amend the proposed s

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Juan Manuel Macías
Hi all, Thanks for your comments, Bastien and Nicolas. I think macros can work out of the box as a perfect 'backend' for those LaTeX commands that include at least one argument with textual content. In my case they are very useful to 'extend' the markup language. Apart from the LaTeX example that

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Bastien
Nicolas Goaziou writes: > So, again, I'm not saying we should do this. TBH, I'm not convinced by > the idea of duplicate syntax (comma-escaping and alternate characters) > for the same thing. But hard-core macro users may have a word to say > about it. FWIW I'm not convinced too but I'd also lov

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Bastien
Nicolas Goaziou writes: > So, maybe it is a bit early to close it. Okay, thanks for the heads up, I'm reopening then. -- Bastien

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Nicolas Goaziou
Hello, Bastien writes: > thank you for the patch. I understand the general idea, but I think > we should be careful not to overload the macro syntax - escaping the > coma seems okay to me. I'm closing this suggestion. > > I'm cc'ing Nicolas: if he thinks it's a useful addition, I won't of > co

Re: [PATCH] Possibility of using alternative separators in macros

2021-05-01 Thread Bastien
Hi Juan, thank you for the patch. I understand the general idea, but I think we should be careful not to overload the macro syntax - escaping the coma seems okay to me. I'm closing this suggestion. I'm cc'ing Nicolas: if he thinks it's a useful addition, I won't of course insist on rejecting it