Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-16 Thread James N . V . Cash
Kyle Meyer writes: > Basil L. Contovounesios writes: >> How involved would it be to make org-eldoc work in >> non-"backwards-compatibility" mode? > > I think we can do that, while still supporting Org's minimum Emacs > version, by following python.el. Here's what it does: > ... > > ... org-eldoc

Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-15 Thread Kyle Meyer
Basil L. Contovounesios writes: > "James N. V. Cash" writes: > >> This patch makes it continue to work by setting the new variable >> eldoc-documentation-strategy, which puts eldoc in >> "backwards-compatability" mode. > > How involved would it be to make org-eldoc work in > non-"backwards-compat

Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-15 Thread Basil L. Contovounesios
"James N. V. Cash" writes: > This patch makes it continue to work by setting the new variable > eldoc-documentation-strategy, which puts eldoc in > "backwards-compatability" mode. How involved would it be to make org-eldoc work in non-"backwards-compatibility" mode? > From 5c04048c0d1ed3f80c7dd

Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-13 Thread James N . V . Cash
Nicolas Goaziou writes: > Do we need another variable for that? Could > org-eldoc-documentation-function catch wrong-number-of-arguments error, > and try another call instead? I believe that the issue is org-eldoc-documentation-function itself is called with the wrong number of arguments; the

Re: [PATCH] Make org-eldoc work with Emacs 28

2020-07-13 Thread Nicolas Goaziou
Hello, "James N. V. Cash" writes: > In Emacs 28, eldoc now passes in a callback to the documentation > functions. This breaks org-eldoc as it currently is, as > org-eldoc-documentation-function gets called with the wrong number of > arguments. > > This patch makes it continue to work by setting