Re: [PATCH] Improve the clock-out message

2025-02-24 Thread Ihor Radchenko
Rudolf Adamkovič writes: > Ihor, if you are OK with this version, please merge. :) Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=67de496b1e -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org

Re: [PATCH] Improve the clock-out message

2025-02-24 Thread Rudolf Adamkovič
Kévin Le Gouguec writes: > One question: should it be "before saving" or "before exiting"? [...] I gave this some more thought, and you are right. From the user's POV, the question is *not* about saving but about clocking out. Saving is implied. I updated the message, and the commit message t

Re: [PATCH] Improve the clock-out message

2025-02-23 Thread Kévin Le Gouguec
Ihor Radchenko writes: > Kévin Le Gouguec writes: > >> Seconded, thanks for taking the time to tweak this! I sometime clock in >> to some task that may require restarting Emacs (or the DE session, or >> the computer); the message no longer gives me pause but it would be good >> to spare future

Re: [PATCH] Improve the clock-out message

2025-02-23 Thread Ihor Radchenko
Kévin Le Gouguec writes: > Seconded, thanks for taking the time to tweak this! I sometime clock in > to some task that may require restarting Emacs (or the DE session, or > the computer); the message no longer gives me pause but it would be good > to spare future users. > > One question: should

Re: [PATCH] Improve the clock-out message

2025-02-02 Thread Kévin Le Gouguec
Rudolf Adamkovič writes: > Rudolf Adamkovič writes: > >> * lisp/org-clock.el (org-clock-kill-emacs-query): Reword the "Clock >> out and save?" message to "Clock out before saving?" to convey the >> important fact that no data will be lost when answered "no". > > I forgot to prefix the commit tit

Re: [PATCH] Improve the clock-out message

2025-02-02 Thread Rudolf Adamkovič
Rudolf Adamkovič writes: > * lisp/org-clock.el (org-clock-kill-emacs-query): Reword the "Clock > out and save?" message to "Clock out before saving?" to convey the > important fact that no data will be lost when answered "no". I forgot to prefix the commit title with the package name. See the a