Rudolf Adamkovič writes:
> * lisp/org-table.el (org-table-make-reference): Replace 'eq' with
> 'string-empty-p' to resolve "Warning: 'eq' called with literal string
> that may never match" issued on every 'make' invocation.
Handled, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/c
Thank you for the explanation!
Given the complexity of the caller, that is
the `org-table-eval-formula' function, as
well as, the fact that I have yet to learn
about the spreadsheet functionality, I am
backing away from this bugfix.
Sorry for the noise.
Rudy
--
"Programming reliably -- must be
Rudolf Adamkovič writes:
> Ihor Radchenko writes:
>
>> This is not as trivial. Applying this patch will break tests.
>> One needs to carefully examine the org-table logic to fix this
>> particular warning.
>
> Wow! You are right. How is that even possible? In other words, what
> value (of 'el
Ihor Radchenko writes:
> This is not as trivial. Applying this patch will break tests.
> One needs to carefully examine the org-table logic to fix this
> particular warning.
Wow! You are right. How is that even possible? In other words, what
value (of 'elements') can possibly be object-equal
Rudolf Adamkovič writes:
> * lisp/org-table.el (org-table-make-reference): Replace 'eq' with
> 'string-empty-p' to resolve "Warning: 'eq' called with literal string
> that may never match" issued on every 'make' invocation.
>
> - (if (and (eq elements "") (not keep-empty))
> + (if