Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Kevin Foley writes: > Kyle Meyer writes: > >> Kevin, could you look into updating the test to avoid changing the repo >> state? > > Sorry about that. Do you have any suggestions on how to avoid changing > the state or any examples of similar tests? > > I tried the following to replace the file w

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Kyle Meyer writes: > Kevin, could you look into updating the test to avoid changing the repo > state? Sorry about that. Do you have any suggestions on how to avoid changing the state or any examples of similar tests? I tried the following to replace the file with it's original contents but it

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin and Bastien, This change (010d1e3b6) needs a follow-up patch. Running the tests now leaves the working tree dirty: diff --git a/testing/examples/babel.org b/testing/examples/babel.org index b0942800a..e95a65b85 100644 --- a/testing/examples/babel.org +++ b/testing/examples/babel.org @@

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin, I was able to apply the patch, I just did so against master. I also added you to the list of contributors here: https://orgmode.org/worg/org-contribute.html Thanks a lot! -- Bastien

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Bastien, Bastien writes: > I tried to apply your patch but I was not able to apply it, perhaps > just a problem with extracting it from your email. > > Can you send an (perhaps updated) version as an attachment? What issue did you have? I was able to download and apply the original patch to

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin, Kevin Foley writes: > I've completed the copyright assignment so should be good to go with > this. great, thanks for letting us know! > Haven't had a chance to see if any conflicts have come up in the > meantime but will try to take a look today. I tried to apply your patch but I wa

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi, I've completed the copyright assignment so should be good to go with this. Haven't had a chance to see if any conflicts have come up in the meantime but will try to take a look today. Kevin

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin, Kevin Foley writes: > Thank you for the feedback! I'm working with my employer regarding > copyright assignment and should have that sorted out shortly. I'll > submit the proposed changes once that's taken care. great, thanks a lot for taking the time to go through this! -- Basti

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Bastien, Thank you for the feedback! I'm working with my employer regarding copyright assignment and should have that sorted out shortly. I'll submit the proposed changes once that's taken care. Kevin Bastien writes: > Hi Kevin, > > this looks good. The patch is significant enough that w

Re: [PATCH] Fix `org-babel-detangle' handling of false positives

Hi Kevin, this looks good. The patch is significant enough that we need you to sign the FSF copyright assignment papers. Here is the form: https://code.orgmode.org/bzg/org-mode/raw/master/request-assign-future.txt Once you're done with this, we can push your commit. Should you contribute more