Nicolas Goaziou writes:
> Eric Abrahamsen writes:
>
>> If I remove the two `eval's and treat "hook" like a normal variable, the
>> call to `length' fails with:
>>
>> Wrong type argument: sequencep, org-mime-pre-org-hook
>>
>> So apparently `length' is seeing the symbol name, and not the symbol
>
Eric Abrahamsen writes:
> If I remove the two `eval's and treat "hook" like a normal variable, the
> call to `length' fails with:
>
> Wrong type argument: sequencep, org-mime-pre-org-hook
>
> So apparently `length' is seeing the symbol name, and not the symbol
> value.
Indeed.
> I tried changin
Nicolas Goaziou writes:
> Hello,
>
> Eric Abrahamsen writes:
>
>> Subject: [PATCH] org-mime.el: Avoid use of letf/cl-letf
>
> Thank you. Some comments follow.
>
>> +(let* ((mp (lambda (p)) (org-entry-get nil p
>> org-mime-use-property-inheritance))
>
> It should be
>
> (mp (lambda (p) (or
Hello,
Eric Abrahamsen writes:
> Subject: [PATCH] org-mime.el: Avoid use of letf/cl-letf
Thank you. Some comments follow.
> +(let* ((mp (lambda (p)) (org-entry-get nil p
> org-mime-use-property-inheritance))
It should be
(mp (lambda (p) (org-entry-get )))
> + (let ((bhook
> +
Nicolas Goaziou writes:
> Hello,
>
> Eric Abrahamsen writes:
>
>> It's amazing what an effect barky compiler errors can have.
>
> Thanks. However, `cl-flet' is not supported in Emacs 23 so it's not an
> option for Org 8.3.
>
> OTOH, most uses of `flet' can be replaced with a plain `lambda' and
>
Nicolas Goaziou writes:
> Hello,
>
> Eric Abrahamsen writes:
>
>> It's amazing what an effect barky compiler errors can have.
>
> Thanks. However, `cl-flet' is not supported in Emacs 23 so it's not an
> option for Org 8.3.
Oh, okay -- I guess I'd never really been aware of what Emacs version we
Hello,
Eric Abrahamsen writes:
> It's amazing what an effect barky compiler errors can have.
Thanks. However, `cl-flet' is not supported in Emacs 23 so it's not an
option for Org 8.3.
OTOH, most uses of `flet' can be replaced with a plain `lambda' and
funcalls.
> -(flet ((mp (p) (org-entr
