Re: [O] ob-sed

Bjarte Johansen writes: >> On 30 May 2015, at 14:32, Nicolas Goaziou wrote: >> >> Bjarte Johansen writes: >> >>> I think I have addressed all of your comments except I didn’t >>> understand the comment about the spaces. Are there two spaces extra or >>> do you want me to introduce two spaces

Re: [O] ob-sed

Bjarte Johansen writes: > From 3efecb4b439d357b30acb67ad5327fec987f76da Mon Sep 17 00:00:00 2001 > From: Bjarte Johansen > Date: Thu, 28 May 2015 13:29:09 +0200 > Subject: [PATCH] Org Babel now supports sed scripts Applied. Thank you. Regards,

Re: [O] ob-sed

> On 30 May 2015, at 14:32, Nicolas Goaziou wrote: > > Bjarte Johansen writes: > >> I think I have addressed all of your comments except I didn’t >> understand the comment about the spaces. Are there two spaces extra or >> do you want me to introduce two spaces somewhere? > > As Suvayu Ali po

Re: [O] ob-sed

Bjarte Johansen writes: > I think I have addressed all of your comments except I didn’t > understand the comment about the spaces. Are there two spaces extra or > do you want me to introduce two spaces somewhere? As Suvayu Ali pointed out, sentences in comments and docstrings are expected to be

Re: [O] ob-sed

Hi Bjarte, On Fri, May 29, 2015 at 03:32:51PM +0200, Bjarte Johansen wrote: > > > >> +(defun org-babel-execute:sed (body params) > >> + "Execute a block of sed code with Org Babel. > >> +BODY is the source inside a sed source block and PARAMS is an > >> +association list over the source block co

Re: [O] ob-sed

I think I have addressed all of your comments except I didn’t understand the comment about the spaces. Are there two spaces extra or do you want me to introduce two spaces somewhere? I have attached the updated patch. Regards, Bjarte 0001-Org-Babel-now-supports-sed-scripts.patch Description:

Re: [O] ob-sed

Bjarte Johansen writes: > I think I have addressed all your comments in the attached patch. Thank you. Some more comments follow. > Subject: [PATCH] Org Babel now supports sed scripts You should add something like the following to your commit message: * doc/org.texi: Signal new Babel langua

Re: [O] ob-sed

I think I have addressed all your comments in the attached patch. Regards, Bjarte 0001-Org-Babel-now-supports-sed-scripts.patch Description: Binary data

Re: [O] ob-sed

Hello, Bjarte Johansen writes: > I had loosely based it on my own ob-sparql and ob-awk, I saw that > there was a remnant of ob-sparql left in there. Here is an updated > version. Thank you. Some comments follow. > ;;; ob-sed.el --- org-babel functions for sed scripts > > ;; Copyright (C) 2015

Re: [O] ob-sed

I had loosely based it on my own ob-sparql and ob-awk, I saw that there was a remnant of ob-sparql left in there. Here is an updated version. ob-sed.el Description: Binary data