Re: [O] inherit priority

2018-07-18 Thread Nicolas Goaziou
Hello, Jesse Johnson writes: > Since you want to comment I guess you want the patch in the e-mail > body rather than attached. Here goes nothing. Thank you! It looks good. Some minor comments follow. > From bb02cd6c00b32155c0a25f409f1bfa4160b2ddcd Mon Sep 17 00:00:00 2001 > From: Jesse Johnso

Re: [O] inherit priority

2018-07-09 Thread Jesse Johnson
Hi Nicolas, On 07/09/2018 01:22 AM, Nicolas Goaziou wrote: It looks good. Could you send it on this ML as a patch so I can comment it more conveniently? Since you want to comment I guess you want the patch in the e-mail body rather than attached. Here goes nothing. From bb02cd6c00b32155c0a2

Re: [O] inherit priority

2018-07-09 Thread Nicolas Goaziou
Hello, Jesse Johnson writes: > Here is my branch adding priority inheritance. > > remote: https://code.orgmode.org/holocronweaver/org-mode.git It looks good. Could you send it on this ML as a patch so I can comment it more conveniently? Thank you. Regards, -- Nicolas Goaziou

Re: [O] inherit priority

2018-07-07 Thread Jesse Johnson
Hi all, Here is my branch adding priority inheritance. remote: https://code.orgmode.org/holocronweaver/org-mode.git branch: inherit-priority-squashed I rebased upon the latest master, everything still seems to work. Sorry for the long delay in release. Please test and critique. Thanks! Je

Re: [O] inherit priority

2018-04-26 Thread Bastien
Hi Jesse, Jesse Johnson writes: > Crazy timing! I've been testing my implementation for a few months, > made some big adjustments a couple weeks ago and plan to submit a > patch this weekend. Nice, thanks in advance - also, when it comes to inheritance, we can hit performance issues. Let's mak

Re: [O] inherit priority

2018-04-26 Thread Jesse Johnson
On 04/26/2018 04:34 PM, Bastien wrote: There have been several requests for priority inheritance over the years. If it can't currently be done, I am willing to take a look at implementing it. Did you make progress on this? Crazy timing! I've been testing my implementation for a few months, m

Re: [O] inherit priority

2018-04-26 Thread Bastien
Hi Jesse, Jesse Johnson writes: > There have been several requests for priority inheritance over the > years. If it can't currently be done, I am willing to take a look at > implementing it. Did you make progress on this? FWIW I'm not convinced it is worth implementing priority inheritance, an

Re: [O] inherit priority

2018-01-08 Thread Nicolas Goaziou
Hello, Jesse Johnson writes: > I am trying to determine the functions I need to add / update to > respect priority inheritance. > > I see that org-show-priority would need to be updated, Correct, but that would be a minor change. > and likely > a new function, say org-get-priority-with-inherit

Re: [O] inherit priority

2018-01-07 Thread Jesse Johnson
Hi, I am trying to determine the functions I need to add / update to respect priority inheritance. I see that org-show-priority would need to be updated, and likely a new function, say org-get-priority-with-inheritance, should supplement org-get-priority. However, I can't figure out where

Re: [O] inherit priority

2018-01-04 Thread Nicolas Goaziou
Hello, Jesse Johnson writes: > There have been several requests for priority inheritance over the > years. That doesn't ring a bell. > If it can't currently be done, I don't think it can, atm. > I am willing to take a look at implementing it. OK! IMO, there should be a global variable to

Re: [O] inherit priority

2018-01-04 Thread Jesse Johnson
There have been several requests for priority inheritance over the years. If it can't currently be done, I am willing to take a look at implementing it. On 01/04/2018 12:15 AM, Nicolas Goaziou wrote: Hello, Jesse Johnson writes: 1. Set |org-use-property-inheritance '("PRIORITY")| 2. Crea

Re: [O] inherit priority

2018-01-04 Thread Nicolas Goaziou
Hello, Jesse Johnson writes: > 1. Set |org-use-property-inheritance '("PRIORITY")| > > 2. Create a new org file with this content: > > * [#A] parent > ** child A > ** child B > > 3. View org-columns (C-c C-x C-c in my setup) > > 4. Note that the children have priority B, while parent has priorit

Re: [O] inherit priority

2018-01-03 Thread Jesse Johnson
Hi! I don't know what an ECM is in this context, but I assume you mean a minimal reproducible case. 1. Set |org-use-property-inheritance '("PRIORITY")| 2. Create a new org file with this content: * [#A] parent ** child A ** child B 3. View org-columns (C-c C-x C-c in my setup) 4. Note that

Re: [O] inherit priority

2018-01-03 Thread Nicolas Goaziou
Hello, Jesse Johnson writes: > I want child org items to inherit priority from their parent. > > I tried setting |org-use-property-inheritance '("PRIORITY")|, but it > did not have any apparent effect. What did you try exactly, i.e., how could you show an ECM demonstrating the issue? Regards,