Re: [O] asynchronous exporter and babel confirmation

2013-03-10 Thread Alan Schmitt
Nicolas Goaziou writes: > Hello, > > Achim Gratz writes: > >> Done in commit 4f7d514f13. The double hyphens have been omitted based >> on a discussion with Eric Schulte. > > Applied to ox.el in commit 69c617c. Thanks a lot! Alan

Re: [O] asynchronous exporter and babel confirmation

2013-03-09 Thread Nicolas Goaziou
Hello, Achim Gratz writes: > Done in commit 4f7d514f13. The double hyphens have been omitted based > on a discussion with Eric Schulte. Applied to ox.el in commit 69c617c. Thank you. Regards, -- Nicolas Goaziou

Re: [O] asynchronous exporter and babel confirmation

2013-03-09 Thread Achim Gratz
Nicolas Goaziou writes: > I will wait for this patch to be committed. Done in commit 4f7d514f13. The double hyphens have been omitted based on a discussion with Eric Schulte. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Achim Gratz
Nicolas Goaziou writes: > I think you mean (or () ()) Yes of course, thanks for catching that. This also means that the testsuite isn't picking upon that. > I will wait for this patch to be committed. When and if Eric chimes in and Karl confirms that his earlier problem with this change

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Nicolas Goaziou
Thanks for considering the changes. Achim Gratz writes: > + (org-babel-call-process-region-original > + (if (org-bound-and-true-p > org-babel-call-process-region-original) > + (symbol-function 'call-process-region))) I think you mean (or () (...

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Achim Gratz
Nicolas Goaziou writes: > `org-babel--suppress-confirm-evaluate-answer-no' to t from > `org-export-async-start'. I would suggest a shorter variable name, I've dropped the "suppress-" as it is redundant, but kept the "confirm-evaluate". >> -;;; ob-core.el --- working with code blocks in org-mode >

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Nicolas Goaziou
Achim Gratz writes: > I'm still waiting for feedback from Karl Voit over in the other thread, > but here's the amended patch for you to review: Thanks. I haven't much to say wrt to the internals since the only thing needed to make use of this patch is to set `org-babel--suppress-confirm-evaluate

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Achim Gratz
Hi Nicolas, I'm still waiting for feedback from Karl Voit over in the other thread, but here's the amended patch for you to review: >From c49b4ab5afda4d223cbcf97cb8c7ac0f9cc8e39b Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Wed, 27 Feb 2013 22:55:26 +0100 Subject: [PATCH] ob-core: do not ask

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Alan Schmitt
Achim Gratz writes: > I've recently refactored the evaluation check so it determines first whether > the > code-block should be run and only in the affirmative checks if it should query > the user. So it should be much easier now to have another dynamic binding for > preventing the question _and

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Nicolas Goaziou
Hello, Achim Gratz writes: >> A very ugly hack would be to use: >> >> (defalias 'yes-or-no-p 'ignore) > > Ugh. I hope this won't be necessary. I hope too. > I've recently refactored the evaluation check so it determines first whether > the > code-block should be run and only in the affirma

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Achim Gratz
Nicolas Goaziou gmail.com> writes: > Well, no, but its somewhat difficult to prevent it. Besides security > considerations, even if we set `org-confirm-babel-evaluate' to nil > during an asynchronous export, this won't handle the case of the user > explicitly uses a :query keyword in a source bloc

Re: [O] asynchronous exporter and babel confirmation

2013-03-06 Thread Nicolas Goaziou
Hello, Alan Schmitt writes: > Is the asynchronous exporter supposed to work when a request to evaluate > a code block needs to be answered? Well, no, but its somewhat difficult to prevent it. Besides security considerations, even if we set `org-confirm-babel-evaluate' to nil during an asynchron