Re: [O] M-RET slow

2013-05-01 Thread Samuel Wales
Hi Bastien, On 4/27/13, Bastien wrote: > Samuel Wales writes: > >> If I run it using M-:, it is fast. If I run it using a key binding, >> it is a bit slow (about 1s). > > Then this is about `org-meta-return', not `org-insert-heading'. > > What is the value of `org-catch-invisible-edits' in your

Re: [O] M-RET slow

2013-04-27 Thread Bastien
Hi Samuel, Samuel Wales writes: > If I run it using M-:, it is fast. If I run it using a key binding, > it is a bit slow (about 1s). Then this is about `org-meta-return', not `org-insert-heading'. What is the value of `org-catch-invisible-edits' in your config? -- Bastien

Re: [O] M-RET slow

2013-04-27 Thread Samuel Wales
Hi Nicolas, On 4/26/13, Nicolas Goaziou wrote: > I pushed a speed-up for `org-insert-heading'. Is it speed acceptable > now? If I run it using M-:, it is fast. If I run it using a key binding, it is a bit slow (about 1s). C-RET is fast using a key binding. So perhaps there is some interaction

Re: [O] M-RET slow

2013-04-26 Thread Bastien
Nicolas Goaziou writes: > Looks like there so work to be done in the 8.x series ;) Sigh. All the work we did already looks shallow compared to what we have to do... I guess that's just part of the game! -- Bastien

Re: [O] M-RET slow

2013-04-26 Thread Nicolas Goaziou
Bastien writes: > Hi Nicolas, > > Nicolas Goaziou writes: > >> Hello, >> >> Bastien writes: >> >>> Carsten Dominik writes: >>> is org-in-item-p slow? >>> >>> It depends on the size of the list -- see for example this problem, >>> where moving an item within a logbook drawer with many item

Re: [O] M-RET slow

2013-04-26 Thread Bastien
Hi Nicolas, Nicolas Goaziou writes: > Hello, > > Bastien writes: > >> Carsten Dominik writes: >> >>> is org-in-item-p slow? >> >> It depends on the size of the list -- see for example this problem, >> where moving an item within a logbook drawer with many items is too >> slow: >> >> http://thr

Re: [O] M-RET slow

2013-04-26 Thread Nicolas Goaziou
Carsten Dominik writes: > org-insert-heading is up for a rewrite, what a mess :/ And the rewrite should use `org-element-at-point' (once) and have tests for its specifications, like many others interactive core functions. Looks like there so work to be done in the 8.x series ;) Regards, --

Re: [O] M-RET slow

2013-04-26 Thread Carsten Dominik
On 26 apr. 2013, at 16:46, Nicolas Goaziou wrote: > Hello, > > Carsten Dominik writes: > >> is org-in-item-p slow? > > It is slow, and `org-insert-heading' was calling it (directly or > indirectly) four times. OK, thanks for fixing it. org-insert-heading is up for a rewrite, what a mess :/

Re: [O] M-RET slow

2013-04-26 Thread Nicolas Goaziou
Hello, Bastien writes: > Carsten Dominik writes: > >> is org-in-item-p slow? > > It depends on the size of the list -- see for example this problem, > where moving an item within a logbook drawer with many items is too > slow: > > http://thread.gmane.org/gmane.emacs.orgmode/66574 This is a dif

Re: [O] M-RET slow

2013-04-26 Thread Nicolas Goaziou
Hello, Carsten Dominik writes: > is org-in-item-p slow? It is slow, and `org-insert-heading' was calling it (directly or indirectly) four times. Regards, -- Nicolas Goaziou

Re: [O] M-RET slow

2013-04-26 Thread Bastien
Carsten Dominik writes: > is org-in-item-p slow? It depends on the size of the list -- see for example this problem, where moving an item within a logbook drawer with many items is too slow: http://thread.gmane.org/gmane.emacs.orgmode/66574 -- Bastien

Re: [O] M-RET slow

2013-04-26 Thread Carsten Dominik
On 26 apr. 2013, at 16:18, Nicolas Goaziou wrote: > Hello, > > Bastien writes: > >> Hi Samuel, >> >> Samuel Wales writes: >> >>> In recent git, M-RET takes a few seconds before it does anything. I >>> wonder what sophisticated calculation it is doing? :) >> >> You can debug the function

Re: [O] M-RET slow

2013-04-26 Thread Nicolas Goaziou
Hello, Bastien writes: > Hi Samuel, > > Samuel Wales writes: > >> In recent git, M-RET takes a few seconds before it does anything. I >> wonder what sophisticated calculation it is doing? :) > > You can debug the function > > C-h f org-insert-heading RET > > then jump on its definition and

Re: [O] M-RET slow

2013-04-25 Thread Bastien
Hi Samuel, Samuel Wales writes: > In recent git, M-RET takes a few seconds before it does anything. I > wonder what sophisticated calculation it is doing? :) You can debug the function C-h f org-insert-heading RET then jump on its definition and M-x edebug-defun RET at the end to follow w