Re: [O] Bug: inline images for filenames with spaces

2011-07-04 Thread Bastien
Hi Huy, Thanks for confirming the fix is okay! Huy writes: > I don't know how to do any exporting yet. Try the magic keystroke in any Org file: C-c C-e HTH, -- Bastien

Re: [O] Bug: inline images for filenames with spaces

2011-07-04 Thread Huy
On Thu, Jun 30, 2011 at 05:41:55PM +0200, Bastien wrote: > Hi Huy, > > Huy writes: > > > inline image display doesn't seem to work for image links with spaces in > > them. > > The attached patch fixes this. > > Please confirm and also take the time to check that there is no > side-effects -

Re: [O] Bug: inline images for filenames with spaces

2011-07-01 Thread Bastien
Hi Manuel, Manuel Giraud writes: > AFAIU, now a link to an inline image inserted with org-insert-link will > expand into [[file name.jpg]] instead of [[file%20name.jpg][file > name.jpg]]. But the later form still doesn't work so it have to be > fixed into older org files. Yes, exactly. -- B

Re: [O] Bug: inline images for filenames with spaces

2011-07-01 Thread Manuel Giraud
Bastien writes: > Hi Huy, > > Bastien writes: > >>> I'm not exporting. >>> I'm just doing C-c C-x C-v to display the inline images within emacs. >> >> I confirm there is a bug here, I'm on it. > > I've pushed the fix now, please test it! I've tested your patch. It works with org-toggle-inline-i

Re: [O] Bug: inline images for filenames with spaces

2011-07-01 Thread Bastien
Hi Huy, Bastien writes: >> I'm not exporting. >> I'm just doing C-c C-x C-v to display the inline images within emacs. > > I confirm there is a bug here, I'm on it. I've pushed the fix now, please test it! Thanks, -- Bastien

Re: [O] Bug: inline images for filenames with spaces

2011-06-30 Thread Bastien
Hi Manuel, Manuel Giraud writes: > Huy writes: > >> Example: >> [[file:img/test.png]] will display inline >> [[file:img/test copy.png]] won't > > Just tested on the same emacs version and few minutes old org-mode and > both works for me. How do you export? Do you have some special > settings?

Re: [O] Bug: inline images for filenames with spaces

2011-06-30 Thread Bastien
Hi Huy, Huy writes: > inline image display doesn't seem to work for image links with spaces in > them. That's because those images will be inserted as [[file:image%20with%20space.png][file:image with space.png]] and such a string is not recognized by the inline displayer. The attached patc

Re: [O] Bug: inline images for filenames with spaces

2011-06-30 Thread Bastien
Hi Huy, Huy writes: > I'm not exporting. > I'm just doing C-c C-x C-v to display the inline images within emacs. I confirm there is a bug here, I'm on it. -- Bastien

Re: [O] Bug: inline images for filenames with spaces

2011-06-29 Thread Huy
I'm not exporting. I'm just doing C-c C-x C-v to display the inline images within emacs. On Wed, Jun 29, 2011 at 01:34:36PM +0200, Manuel Giraud wrote: > Huy writes: > > > Example: > > [[file:img/test.png]] will display inline > > [[file:img/test copy.png]] won't > > Just tested on the same em

Re: [O] Bug: inline images for filenames with spaces

2011-06-29 Thread Manuel Giraud
Huy writes: > Example: > [[file:img/test.png]] will display inline > [[file:img/test copy.png]] won't Just tested on the same emacs version and few minutes old org-mode and both works for me. How do you export? Do you have some special settings? -- Manuel Giraud