Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-03 Thread Kyle Meyer
Nicolas Goaziou wrote: [...] > Applied with a minor tweak: boundp -> fboundp. Thanks for catching that. -- Kyle

Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-03 Thread Nicolas Goaziou
Kyle Meyer writes: > I've attached an updated patch. It now includes a comment about which > version removed isearch-other-control-char, and the commit message has > been extended to explain why both 'C-m' and RET are bound to nil. Applied with a minor tweak: boundp -> fboundp. Thank you. Reg

Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-03 Thread Kyle Meyer
Nicolas Goaziou wrote: [...] > OK. So let's bind both of them to nil then. Thanks for the > investigation. I've attached an updated patch. It now includes a comment about which version removed isearch-other-control-char, and the commit message has been extended to explain why both 'C-m' and RET a

Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-03 Thread Nicolas Goaziou
Kyle Meyer writes: > To follow up on this: > > I think the reason why setting only one doesn't work is because isearch > specifies both of them. > > (define-key map "\r" 'isearch-exit) > (define-key map [return] 'isearch-exit) > > Since the return key is given a binding, it's not translat

Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-02 Thread Kyle Meyer
Kyle Meyer wrote: > Nicolas Goaziou wrote: > [...] >> However, C-m is RET. Is there any reason to distinguish between the two? > > If I use just > > (define-key org-goto-local-auto-isearch-map [return] nil) > > then C-m doesn't work (i.e., it results in isearch-exit being called > instead of

Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-02 Thread Kyle Meyer
Nicolas Goaziou wrote: [...] > However, C-m is RET. Is there any reason to distinguish between the two? If I use just (define-key org-goto-local-auto-isearch-map [return] nil) then C-m doesn't work (i.e., it results in isearch-exit being called instead of org-goto-ret, then requiring a seco

Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-02 Thread Nicolas Goaziou
Kyle Meyer writes: > Hmm, I tried that (and just checked it again), but it doesn't work on my > end. C-m will exit isearch but not the indirect org-goto buffer. A > second C-m is needed to get back to the main buffer. (This is also true > for return, which is why it is also set to nil.) For C-i,

Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-02 Thread Kyle Meyer
Nicolas Goaziou wrote: [...] > C-i and C-m seem to work out the box in Emacs 24.4 anyway. Maybe the > following is sufficient: > > (when (fboundp 'isearch-other-control-char) > (define-key ...) > (define-key ...)) > > I.e, no need to bind these keys to nil. Hmm, I tried that (and just c

Re: [O] [RFC/PATCH] org-goto: Update for isearch changes

2014-11-02 Thread Nicolas Goaziou
Hello, Kyle Meyer writes: > As of Emacs 24.4, isearch no longer has the function > isearch-other-control-char, which is bound in > org-goto-local-auto-isearch-map. > > I've attached a patch that seems to produce the correct behavior with > Emacs 24.4. However, I haven't used this interface enoug