Nicolas Goaziou writes:
>> The new tests don't work on Emacs23, mainly due to the use of cl-letf.
>
> I fixed the `cl-letf' issue, thank you. Is there anything else to do?
Not with respect to this change, the tests are now all passing.
However, Emacs master seems to have changed the signature for
Hello,
Achim Gratz writes:
> The new tests don't work on Emacs23, mainly due to the use of cl-letf.
I fixed the `cl-letf' issue, thank you. Is there anything else to do?
Regards,
--
Nicolas Goaziou
Nicolas Goaziou writes:
> Applied (with a minor change in `org-timer--get-timer-title'). Thank you.
The new tests don't work on Emacs23, mainly due to the use of cl-letf.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Waldorf MIDI Implementation & addit
Kyle Meyer writes:
> I've attached updated patches.
Applied (with a minor change in `org-timer--get-timer-title'). Thank you.
Regards,
Nicolas Goaziou wrote:
> Kyle Meyer writes:
>
>> Do you prefer to add fixes for the current design, or just move
>> directly to merging the two APIs?
>
> The latter sounds better.
I've attached updated patches.
>From da0454ea110de0b4effb59ec220d8e15960fbf84 Mon Sep 17 00:00:00 2001
From: Kyle M
Kyle Meyer writes:
> Do you prefer to add fixes for the current design, or just move directly
> to merging the two APIs?
The latter sounds better.
>> Also, some comments at the beginning of the library could help.
>>
>> AFAIK, there are no tests for timers. Adding a new "test-timer.el" with
>>
Nicolas Goaziou wrote:
[...]
>> However, I'd actually be in favor of removing this functionality
>> from org-timer (and org-timer-start) since it's already available
>> directly through the interactive command
>> org-timer-change-times-in-region.
>
> It saves a keybinding (`org-tim
Hello,
Kyle Meyer writes:
> I've attached a few patches for org-timer.el.
Thank you.
> Some additional comments on two of the patches:
>
> [PATCH 1/4] org-timer.el (org-timer): Recognize double prefix
>
> This patch makes org-timer behave as described in the docstring when
> it is give
