Re: [O] [Patch] Fix handling of variable capture location

2017-05-19 Thread Nicolas Goaziou
Hello, Yuri Lensky writes: > I now understand what you mean by the second call to symbol-value not being > needed. The previous behavior only chose this "branch" of the cond if > symbol-value was not nil. To keep this behavior but only have one call to > symbol-value, why not change to (keep the

Re: [O] [Patch] Fix handling of variable capture location

2017-05-19 Thread Yuri Lensky
Thanks! I now understand what you mean by the second call to symbol-value not being needed. The previous behavior only chose this "branch" of the cond if symbol-value was not nil. To keep this behavior but only have one call to symbol-value, why not change to (keep the symbol-value in the cond as

Re: [O] [Patch] Fix handling of variable capture location

2017-05-19 Thread Nicolas Goaziou
Hello, Yuri Lensky writes: > The second call is indeed needed. AFAICT, it isn't. (cond ('foo) (t nil)) => 'foo > This is the case fixed by the patch: > > (setq org-default-notes-file (expand-file-name "~/docs/notes.org")) > (setq org-capture-templates '(("t" "Todo" entry (file+olp > org-d

Re: [O] [Patch] Fix handling of variable capture location

2017-05-17 Thread Yuri Lensky
The second call is indeed needed. This is the case fixed by the patch: (setq org-default-notes-file (expand-file-name "~/docs/notes.org")) (setq org-capture-templates '(("t" "Todo" entry (file+olp org-default-notes-file "Inbox") "* TODO %?\n%i"))) This breaks without the second symbol-value. The

Re: [O] [Patch] Fix handling of variable capture location

2017-05-17 Thread Nicolas Goaziou
Hello, Yuri Lensky writes: > Capture locations in variable not working before this patch. Thank you. Could you show an example demonstrating the issue? The only difference I can see with your patch is that you're referring to the global value of file, not the local one. > From c0de1c390b370b