Re: [O] [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.

2018-03-16 Thread Nicolas Goaziou
Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > So I attached two patches: > - the first (0001-ORG-NEWS-...) correct the example in order to match to the > code, > - the second (0001-ob-sql.el...) correct the codein order to match to the > example. > > Personnaly I prefer the l

Re: [O] [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.

2018-03-15 Thread Pierre Téchoueyres
Nicolas Goaziou writes: Hi Nicolas, > ... > It looks good. > > I added two spaces at the end of sentences and pushed it. > ... I'm sorry I did a mistake in the previous patch. There is an inconsistency between the code in `org-babel-sql-dbstring-oracle' and the example provided in the ORG-NEWS f

Re: [O] [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.

2018-03-14 Thread Nicolas Goaziou
Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > Nicolas Goaziou writes: >> ... >> Otherwise, it looks good. Would you mind adding an entry in ORG-NEWS >> about it? > Hello Nicolas, > > What dou you think about the attached patch ? It looks good. I added two spaces at the end o

Re: [O] [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.

2018-03-13 Thread Pierre Téchoueyres
Nicolas Goaziou writes: > ... > Otherwise, it looks good. Would you mind adding an entry in ORG-NEWS > about it? Hello Nicolas, What dou you think about the attached patch ? >From 0103a07b10915ce7c919b8a6858beff3dbd7e45f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= Date:

Re: [O] [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.

2018-03-13 Thread pierre . techoueyres
Hello, Hello Nicolas, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: Hello all Org's developpers, I would like to provide a small improvement to ob-sql : the possibility to connect to an oracle database by using the alias defined in TNSNAMES file. The patch joined here try to ach

Re: [O] [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.

2018-03-13 Thread Nicolas Goaziou
Hello, pierre.techouey...@free.fr (Pierre Téchoueyres) writes: > Hello all Org's developpers, > I would like to provide a small improvement to ob-sql : the possibility to > connect to an oracle database by using the alias defined in TNSNAMES file. > > The patch joined here try to achive this. It