Re: [BUG] Numeric priorities only partially supported

2025-07-21 Thread Ihor Radchenko
Derek Chen-Becker writes: > Sounds good. I'm happy to update the documentation, the regexp, and > other mentioned locations to match one of A-Z or 0-64. Are we OK > restricting it to uppercase only? Yes, let's go for it. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org

Re: [BUG] Numeric priorities only partially supported

2025-07-20 Thread Derek Chen-Becker
Sounds good. I'm happy to update the documentation, the regexp, and other mentioned locations to match one of A-Z or 0-64. Are we OK restricting it to uppercase only? Thanks! Derek On Sat, Jul 19, 2025 at 10:29 AM Ihor Radchenko wrote: > Derek Chen-Becker writes: > > > I guess looking at http

Re: [BUG] Numeric priorities only partially supported

2025-07-19 Thread Ihor Radchenko
Derek Chen-Becker writes: > I guess looking at https://orgmode.org/manual/Priorities.html, it's not > clearly defined what valid ranges are. Are upper and lower cases considered > equivalent? Is it strictly A-Z, or a-z, or 1-64? If it's not numeric, do > we just allow any character whose value is

Re: [BUG] Numeric priorities only partially supported

2025-07-19 Thread Derek Chen-Becker
I guess looking at https://orgmode.org/manual/Priorities.html, it's not clearly defined what valid ranges are. Are upper and lower cases considered equivalent? Is it strictly A-Z, or a-z, or 1-64? If it's not numeric, do we just allow any character whose value is >= 65? For example, 一,二, 三, 四? Tech

Re: [BUG] Numeric priorities only partially supported

2025-07-19 Thread Ihor Radchenko
Derek Chen-Becker writes: > I'm also not clear on why we upcase again when checking the bounds: > > ((or (< (upcase new) org-priority-highest) (> (upcase new) > org-priority-lowest)) That's a historical code. It has been there before the earlier upcase was introduced. Here is the initial versio

Re: [BUG] Numeric priorities only partially supported

2025-07-19 Thread Derek Chen-Becker
Sure, but there's the check in the let to set `nump' based on the highest/lowest priority. I could add that as a condition to the upcase transform: (when (and (= (upcase org-priority-highest) org-priority-highest) (= (upcase org-priority-lowest) org-priority-lowest)

Re: [BUG] Numeric priorities only partially supported

2025-07-19 Thread Ihor Radchenko
Derek Chen-Becker writes: > Just double-checking my understanding of things, but it looks like > `org-priority' already handles number inputs, despite the docstring: > > ((or (eq action 'set) > (integerp action)) > (if (not (eq action 'set)) > (setq

Re: [BUG] Numeric priorities only partially supported

2025-07-19 Thread Derek Chen-Becker
Just double-checking my understanding of things, but it looks like `org-priority' already handles number inputs, despite the docstring: ((or (eq action 'set) (integerp action)) (if (not (eq action 'set)) (setq new action) My read of that is that if t

Re: [BUG] Numeric priorities only partially supported

2025-07-12 Thread Derek Chen-Becker
Thanks for the feedback. Let me rework it per your suggestions. Cheers, Derek On Sat, Jul 12, 2025 at 10:11 AM Ihor Radchenko wrote: > Derek Chen-Becker writes: > > > Summer schedules got the better of me, but here's the first of hopefully > > several patches to address this is small pieces r

Re: [BUG] Numeric priorities only partially supported

2025-07-12 Thread Ihor Radchenko
Derek Chen-Becker writes: > Summer schedules got the better of me, but here's the first of hopefully > several patches to address this is small pieces rather than trying to > commit to one large chunk of work. Tests pass locally and I added some new > ones as well. Thanks! > - (org-priorit

Re: [BUG] Numeric priorities only partially supported

2025-07-10 Thread Derek Chen-Becker
Summer schedules got the better of me, but here's the first of hopefully several patches to address this is small pieces rather than trying to commit to one large chunk of work. Tests pass locally and I added some new ones as well. On Tue, Jun 17, 2025 at 6:29 AM Derek Chen-Becker wrote: > Sound

Re: [BUG] Numeric priorities only partially supported

2025-06-17 Thread Derek Chen-Becker
Sounds good! Handled. On Sun, Jun 8, 2025 at 10:04 AM Ihor Radchenko wrote: > Derek Chen-Becker writes: > > >> We must eventually support numeric properties, as documented in the > manual. > > > > This is actually something I've wanted for a while and never got > > around to looking at it. I'm

Re: [BUG] Numeric priorities only partially supported

2025-06-08 Thread Jacob S. Gordon
Hey Derek, Just tying this together with a recent thread where numeric default priorities are interpreted as characters: https://list.orgmode.org/orgmode/328266e1-4338-4963-a3ae-eb6c51f6d...@frantzen.info/ Thanks, -- Jacob S. Gordon jacob.as.gor...@gmail.com == Please avo

Re: [BUG] Numeric priorities only partially supported

2025-06-08 Thread Ihor Radchenko
Derek Chen-Becker writes: >> We must eventually support numeric properties, as documented in the manual. > > This is actually something I've wanted for a while and never got > around to looking at it. I'm happy to start digging into this if it's > still valid. Yes, this bug still needs to be fix

Re: [BUG] Numeric priorities only partially supported

2025-06-08 Thread Derek Chen-Becker
On Sun, Oct 13, 2024 at 04:11:01PM +, Ihor Radchenko wrote: > Not so safe. I tried to fix this specific issue in the past and changing > the org-element parser to handle non-single char priorities broke > tests (either because I did something stupid or because the tests make > incorrect assumpt

Re: [BUG] Numeric priorities only partially supported

2024-10-13 Thread Ihor Radchenko
Tommy Jollyboat writes: > However, various functions within org-mode are still using > ~string-to-char~ and giving inconsistent results, because numerical > priorities are parsed wrongly, or sometimes return nil (or #10 to > #64). Confirmed. > * SOLUTION > > If we agree that numeric priorities