Re: Image inlining patch

2025-04-10 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > Attached is a new version of the patch. It builds on Ihors refactoring > patch. > Best. /PA Thanks! I toyed around with the patch and I feel that we might be breaking an important use case without recovery. Consider something like #+attr_latex: :centerin

Re: Image inlining patch

2025-04-05 Thread Pedro Andres Aranda Gutierrez
Hi, after giving ox-html a second (and a third read), there are too many dependencies to make a clean move a simple task. It will take me more time than I have right now. So why not fixing the bug now and doing the factoring out later? Best, /PA On Fri, 28 Mar 2025 at 19:31, Ihor Radchenko wrot

Re: Image inlining patch

2025-03-30 Thread Pedro Andres Aranda Gutierrez
Hi again, Attached is a new version of the patch. It builds on Ihors refactoring patch. Best. /PA On Sun, 30 Mar 2025 at 07:24, Pedro Andres Aranda Gutierrez < paag...@gmail.com> wrote: > Thanks! > > Will try out as soon as I have time to. > > /PA > > On Sat, 29 Mar 2025 at 15:44, Ihor Radchenko

Re: Image inlining patch

2025-03-29 Thread Pedro Andres Aranda Gutierrez
Thanks! Will try out as soon as I have time to. /PA On Sat, 29 Mar 2025 at 15:44, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > > > after giving ox-html a second (and a third read), there are too many > > dependencies to make a clean move a simple task. > > It will take me m

Re: Image inlining patch

2025-03-29 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > after giving ox-html a second (and a third read), there are too many > dependencies to make a clean move a simple task. > It will take me more time than I have right now. So why not fixing the bug > now and doing the factoring out later? See the attached p

Re: Image inlining patch

2025-03-28 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > Could be a good idea. I would factor that out and then use a define-alias in > the html and the latex exporters to touch the code as little as possible. > WDYT? We should definitely keep obsolete alias if we move the function from ox-html to ox, but I'd

Re: Image inlining patch

2025-03-27 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > attached is a patch that will inline images and only apply attributes to > standalone images. Thanks! > +(require 'ox-html) > > ;;; Function Declarations > > @@ -49,6 +50,14 @@ > (defvar engrave-faces-current-preset-style) > (defvar engrave-faces-latex

Image inlining patch

2025-03-27 Thread Pedro Andres Aranda Gutierrez
Hi, attached is a patch that will inline images and only apply attributes to standalone images. Sorry, but I've lost the original thread to answer it. Best, /PA -- Fragen sind nicht da, um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler Sagen's Paradeiser, write BE!