> Thanks again for the nice addition.
My pleasure, thanks for all of your feedback.
Also I took another look at adding a test around this, will hopefully
have another patch to submit for that.
Kevin
Kevin Foley writes:
> I'll defer to your pcase solution as I think my reasoning for using
> pcase-let isn't particularly strong and I agree your suggestion is
> cleaner.
Okay, pushed (885ee086d).
Thanks again for the nice addition.
Kyle Meyer writes:
> Kevin Foley writes:
>
>> Side note I'm not sure your example would render properly regardless
>> since `my/bulk-action' and `my/args' aren't functions.
>
> I'm confused by this. They were defined just above the text you
> quoted:
Sorry about that, I completely missed those.
Kevin Foley writes:
> Kyle Meyer writes:
>
>> (setq org-agenda-bulk-custom-functions
>> '((?D my/bulk-action)
>> (?E (my/bulk-action))
>> (?F (my/bulk-action my/args
>> However, customize doesn't render the above value properly
[...]
> Side note I'm not sure your
Kyle Meyer writes:
> Please fill this line (fill-column in .dir-locals.el is set to 70)
> and...
>> [...]
> ... drop this unrelated space change.
Done and done.
> Reading this docstring in full, I felt it was a bit odd to repeat the
> bulk-cut entry from the initial example again, as it stays th
Kevin Foley writes:
> Kyle Meyer writes:
[...]
>> In addition to the NEWS entry that Ihor mentioned, it looks like an
>> update to the manual is missing.
>
> NEWS entry added. With regard to the manual, the custom bulk function
> option is only mentioned as a footnote. I'm happy to add a more i
Kyle Meyer writes:
Thanks for the review Kyle.
> nit: No ":" after "lisp/org-agenda.el".
Fixed.
> Drop either "about" or "for"?
Fixed.
> In addition to the NEWS entry that Ihor mentioned, it looks like an
> update to the manual is missing.
NEWS entry added. With regard to the manual, the c
Kevin Foley writes:
> Attached patch should allow user to specify a function to collect
> arguments when calling a custom bulk function such that those arguments
> are only collected once and used for each entry.
Thanks, Kevin and Ihor. This sounds like a good change to me too.
> Subject: [PATC
Kevin Foley writes:
> Attached patch should allow user to specify a function to collect
> arguments when calling a custom bulk function such that those arguments
> are only collected once and used for each entry.
Looks good for me. Maybe you can also add an entry to ORG-NEWS.
Marking this threa
Attached patch should allow user to specify a function to collect
arguments when calling a custom bulk function such that those arguments
are only collected once and used for each entry.
Kevin Foley
>From dfab64f738f227691d84a2fdec5bba2cf4f1e3b0 Mon Sep 17 00:00:00 2001
From: "Kevin J. Foley"
Da
Kevin Foley writes:
> '((?R (set-category set-category-args))
> (?C bulk-cut))
>
> I mostly went with this because I'm not very familiar with `pcase'.
> I've confirmed it works as expected but let me know if you still think
> another approach is better.
I understand now. I thought you wanted t
Ihor Radchenko writes:
> You need to add extra matcher `(,_ ,argf ,f).
My idea is to keep allow the user to optionally pass a list of argf and
f instead of just a function.
For example if no args need to be collected:
'((?R set-category)
(?C bulk-cut))
but if arguments needs to be collected
Kevin Foley writes:
> +(`(,_ ,f)
> +(when (listp f)
> + (let ((args (funcall (nth 1 f)))
> +(func (nth 0 f)))
> +(setq f (apply #'apply-partially func args
> +(setq cmd f) (setq redo-at-end t))
That will not wor
Ihor Radchenko writes:
> Note that attachment in the previous email appears to be empty. Can you
> resend? I will take a look then.
My mistake, populated file is attached. Thanks.
Kevin
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index dedf7e5bb..1df99ec79 100644
--- a/lisp/org-agenda
Kevin Foley writes:
> I took a look this morning and came up with the attached patch.
> Essentially if the custom function is a list then the first element is
> the bulk function and the second is the argument function.
>
> If that looks reasonable I can add some documentation and submit a
> prop
Ihor Radchenko writes:
> Instead of advice, you can also provide a simple patch implementing the
> described functionality in org-agenda-bulk-action. I do support adding
> this functionality to org.
I took a look this morning and came up with the attached patch.
Essentially if the custom functio
Kevin Foley writes:
> I'd like to setup a custom bulk function using
> `org-agenda-bulk-custom-functions', however I'd like to receive one
> prompt when I select the action and then have the action performed on
> every entry without being prompted again.
Generally, you can set a variable indicat
I'd like to setup a custom bulk function using
`org-agenda-bulk-custom-functions', however I'd like to receive one
prompt when I select the action and then have the action performed on
every entry without being prompted again.
For example the bulk tag function lets the user specify a tag once, the
18 matches
Mail list logo
