Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding

2022-05-27 Thread Ihor Radchenko
Tom Gillespie writes: > I think we might want to update the documentation to mention > issue with evil for now We can, but it will only be required if evil devs don't fix the issue in a reasonable time frame. Best, Ihor

Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding

2022-05-27 Thread Ihor Radchenko
Tom Gillespie writes: >> Note that if evil were to comply with the canonical isearch >> implementation and respect isearch-mode-end-hook, there would be no >> issue. > > I think we might want to update the documentation to mention > issue with evil for now, and alert the evil devs about this chan

Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding

2022-05-27 Thread Tom Gillespie
The workaround from the other thread to (setq org-fold-core-style 'overlays) is perfect. > The whole point of the patch is _not_ using overlays. For performance > reasons. Yep, the workaround is sufficient for now, and the note on performance for large files in the docstring makes it clear what

Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding

2022-05-27 Thread Ihor Radchenko
Tom Gillespie writes: > Might restoring the invisible overlay text property restore > the old behavior? Is there a reason it was removed? The whole point of the patch is _not_ using overlays. For performance reasons. You can, however, switch to the old behavior by setting org-fold-core-style to

Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding

2022-05-27 Thread Tom Gillespie
> It appears to respect isearch-filter-predicate, but not > isearch-mode-end-hook. This is true only when isearch is used as the module via (evil-select-search-module 'evil-search-module 'isearch), and indeed, when using evil search in that way headings no longer refold. When using evil-search, th

Re: [BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding

2022-05-03 Thread Ihor Radchenko
Tom Gillespie writes: > It seems that this patch (as commit > 67275f4664ce00b5263c75398d78816e7dc2ffa6, found using git bisect to > hunt down the issue) breaks search in evil mode when > (evil-select-search-module 'evil-search-module 'evil-search) is set. > The broken behavior is that evil-se

[BUG] 67275f4 broke evil-search Re: [PATCH 10/35] Implement link folding

2022-05-03 Thread Tom Gillespie
Hi Ihor, It seems that this patch (as commit 67275f4664ce00b5263c75398d78816e7dc2ffa6, found using git bisect to hunt down the issue) breaks search in evil mode when (evil-select-search-module 'evil-search-module 'evil-search) is set. The broken behavior is that evil-search no longer searches i

[PATCH 10/35] Implement link folding

2022-01-29 Thread Ihor Radchenko
* lisp/ol.el (org-link--link-folding-spec): (org-link--description-folding-spec): New variables controlling link folding settings. (org-link--reveal-maybe): Handle revealing folded links. (org-link-descriptive-ensure): Implement `org-link-descriptive' support with org-fold. (org-toggle-link-displa