Re: [PATCH] ox.el: Fix extra character deleted in org-export--update-included-link

2020-02-13 Thread Adam Porter
Dear Nicolas and Bastien, I feel like a child whose parents are fighting. :) If I may speak for other Org users: you're invaluable to us, and we look up to you. Please don't let the deficiencies inherent in online, textual communication cause deterioration in your fellowship. With gratitude fo

Re: [PATCH] ox.el: Fix extra character deleted in org-export--update-included-link

2020-02-13 Thread Bastien
Hi Nicolas, I'm glad I replied to your email because... Nicolas Goaziou writes: > Last time we disagreed, you grossly concluded with: > >Future maintainers may of course interpret the recommendations of the >FSF differently, but that's mine for now. > > As far as my understanding permit

Re: [PATCH] ox.el: Fix extra character deleted in org-export--update-included-link

2020-02-13 Thread Nicolas Goaziou
Hello, Bastien writes: > Nicolas Goaziou writes: > >> How would I dare to have an opinion m'lord? Only yours matters. > > Such sarcastic remarks hurt. Indeed! But I eventually overcame the pain. Thank you for caring! :) Last time we disagreed, you grossly concluded with: Future maintainer

Re: [PATCH] ox.el: Fix extra character deleted in org-export--update-included-link

2020-02-13 Thread Bastien
Hi Nicolas, Nicolas Goaziou writes: > How would I dare to have an opinion m'lord? Only yours matters. Such sarcastic remarks hurt. I may have done something (or worse, many things!) that frustrate you somehow, but using irony is not a good way to communicate on mailing lists. Simply tell me d

Re: [PATCH] ox.el: Fix extra character deleted in org-export--update-included-link

2020-02-11 Thread Nicolas Goaziou
Hello, Bastien writes: > Nicolas, does it look good to you? How would I dare to have an opinion m'lord? Only yours matters. Christoffer, unfortunately, this patch is incorrect. It doesn't account for a zero :post-blank value. For the record, (1- (org-element-property :end ...)) is always a b

Re: [PATCH] ox.el: Fix extra character deleted in org-export--update-included-link

2020-02-11 Thread Bastien
Hi Christoffer and Nicolas, thanks for your patch. a...@xkqr.org (Christoffer Stjernlöf) writes: > * ox.el (org-export--update-included-link): Fix bug. > (org-export--update-included-link): Delete region only until one less > than (org-element-property :end link). Nicolas, does it look good to

[PATCH] ox.el: Fix extra character deleted in org-export--update-included-link

2019-11-03 Thread Christoffer Stjernlöf
* ox.el (org-export--update-included-link): Fix bug. (org-export--update-included-link): Delete region only until one less than (org-element-property :end link). The old behaviour meant that e.g. the following headline could fail to parse correctly after inclusion: [[file:something.org][Title]] :