Re: [PATCH] org-src: Improve the name of source editing buffers

2023-03-14 Thread Rudolf Adamkovič
Ihor Radchenko writes: > [...] it may affect existing uses of `display-buffer-alist' [...] Canceled. Yeah, I did not realize it would be a breaking change. Thank you folks for discussing my patch! Rudy -- "Be especially critical of any statement following the word 'obviously.'" -- Anna Pell

Re: [PATCH] org-src: Improve the name of source editing buffers

2023-03-10 Thread Ihor Radchenko
Rudolf Adamkovič writes: > - e.g. "FILE" from Project.el > - e.g. "*EGLOT (PROJECT/(MODE)) events*" from Eglot > - e.g. "magit-diff(FILE1 -- FILE2): PROJECT" from Magit > > All "normal looking" (spacing-wise), unlike e.g. "*Org Src FILE[ MODE ]*". > >> Could you list other packages that use

Re: [PATCH] org-src: Improve the name of source editing buffers

2023-03-08 Thread Rudolf Adamkovič
Ihor Radchenko writes: > net-utils.el also has "*ftp [host]*". Notably, with space. > I found no other use of [...] in Emacs sources. Looking at my buffers, I see: - e.g. "FILE" from Project.el - e.g. "*EGLOT (PROJECT/(MODE)) events*" from Eglot - e.g. "magit-diff(FILE1 -- FILE2): PROJECT" from

Re: [PATCH] org-src: Improve the name of source editing buffers

2023-03-08 Thread Ihor Radchenko
Rudolf Adamkovič writes: > Ihor Radchenko writes: > >> Could you elaborate about "more standard"? > > Sure. For example, when I look at my Mode Line now, I see that the major more > is "Message[Notmuch]". When I look at the names of the currently open > buffers, > I see "FOO" and "{FOO}" and

Re: [PATCH] org-src: Improve the name of source editing buffers

2023-03-07 Thread Rudolf Adamkovič
Ihor Radchenko writes: > Could you elaborate about "more standard"? Sure. For example, when I look at my Mode Line now, I see that the major more is "Message[Notmuch]". When I look at the names of the currently open buffers, I see "FOO" and "{FOO}" and "[FOO] BAR" and "FOO(BAR)". All this is

Re: [PATCH] org-src: Improve the name of source editing buffers

2023-03-07 Thread Ihor Radchenko
Rudolf Adamkovič writes: > * lisp/org-src.el (org-src--construct-edit-buffer-name): Fix the name > given to a source editing buffer. The original format was documented > as "ORG-BUFFER-NAME [ LANG ]" but in reality it was "ORG-BUFFER-NAME[ > LANG ]", with different spacing. We make the format m

Re: [PATCH] org-src: Improve the name of source editing buffers

2023-03-06 Thread Max Nikulin
On 06/03/2023 04:26, Rudolf Adamkovič wrote: -Format is \"*Org Src ORG-BUFFER-NAME [ LANG ]*\"." - (concat "*Org Src " org-buffer-name "[ " lang " ]*")) +Format is \"*Org Src ORG-BUFFER-NAME [LANG]*\"." + (concat "*Org Src " org-buffer-name " [" lang "]*")) May it be a breaking change for use

Re: [PATCH] org-src: Improve the name of source editing buffers

2023-03-05 Thread Rudolf Adamkovič
I had a little bit of spare time today to refine the patch. Changes: - The patch now comes with a test to avoid regressions. - The patch has a slightly better commit message. Please see the attached file. Thank you! Rudy >From a831b9014b3aaef16846dca049882a485ebf1dd6 Mon Sep 17 00:00:00 2001 F

[PATCH] org-src: Improve the name of source editing buffers

2023-03-02 Thread Rudolf Adamkovič
* lisp/org-src.el (org-src--construct-edit-buffer-name): Fix the name given to a source editing buffer. The original format was documented as "ORG-BUFFER-NAME [ LANG ]" but in reality it was 'ORG-BUFFER-NAME[ LANG ]', with different spacing. We make the format more standard and more compact, as w