Re: [PATCH] org-agenda.el: customise outline path in echo area

2022-08-30 Thread Mikhail Skorzhisnkii
I have signed the FSF papers now and we can continue the review of this work now. I am attaching updated and rebased patch for this and another e-mail thread, since these two patches are depend on each other. I have additionally tested the functionality of these changes by verifying that it wor

Re: [PATCH] org-agenda.el: customise outline path in echo area

2022-06-11 Thread Ihor Radchenko
Mikhail Skorzhinskii writes: > Thank you for your comments once again. I've changed string= to eq and > it appears to be working OK. > > I've also renamed "title" variable to "title-prop" for better > readability. The -prop suffix should show the reader that it was > extracted from the file, and

Re: [PATCH] org-agenda.el: customise outline path in echo area

2021-12-28 Thread Mikhail Skorzhinskii
Hi Ihor, Thank you for your comments once again. I've changed string= to eq and it appears to be working OK. I've also renamed "title" variable to "title-prop" for better readability. The -prop suffix should show the reader that it was extracted from the file, and thus cost some CPU/IO. I've att

Re: [PATCH] org-agenda.el: customise outline path in echo area

2021-12-26 Thread Ihor Radchenko
"Mikhail Skorzhinskiy" writes: > Should I resubmit the patch in this thread? I agree with your change. Yes. Just reply to my message with the new version of the patch. Best, Ihor

Re: [PATCH] org-agenda.el: customise outline path in echo area

2021-12-26 Thread Mikhail Skorzhinskiy
Glad to hear that. Should I resubmit the patch in this thread? I agree with your change. Thanks, Mikhail -- Mikhail Skorzhinskiy mskorzhins...@eml.cc On Sun, Dec 26, 2021, at 16:44, Ihor Radchenko wrote: > Mikhail Skorzhinskii writes: > > Thanks for the patch! The addition looks reasonabl

Re: [PATCH] org-agenda.el: customise outline path in echo area

2021-12-26 Thread Ihor Radchenko
Mikhail Skorzhinskii writes: Thanks for the patch! The addition looks reasonable to me. > +    (title (when (and file-or-title (string= file-or-title > 'title)) > ... > +  (and file-or-title bfn (concat (if (and (string= file-or- > title 'title) title) (string= file-or-title 'title)

[PATCH] org-agenda.el: customise outline path in echo area

2021-12-25 Thread Mikhail Skorzhinskii
* lisp/org-agenda.el (org-agenda-show-outline-path): add an option to show document title in outline path (instead of file name) * lisp/org.el (org-get-title-from-file): a function to collect the document title from the org-mode file * lisp/org.el (org-display-outline-path): add logic that will c