Re: Backwards compatibility (was: Re: [PATCH] ob-shell: consistent prefix)

2024-01-20 Thread Ihor Radchenko
Matt writes: > How far does backwards compatibility extend with regard to Org itself? > For the next version, for all time, or something else? Usually, until next major release (we should have major releases more frequently in future). However, we often keep compat code in place even much later

Re: [PATCH] ob-shell: consistent prefix

2024-01-20 Thread Matt
I'm going to defer these changes for now. It seems like it would be easier to handle renaming one function/variable at a time. Renaming requires creating an alias mapping between the old name and the new one. Any subsequent refactoring would require updating the mapping. It seems better to d

Backwards compatibility (was: Re: [PATCH] ob-shell: consistent prefix)

2024-01-20 Thread Matt
On Tue, 16 Jan 2024 14:10:00 +0100 Ihor Radchenko wrote --- > I do not mind changing the names, except that we must not break > backwards compatibility. In particular, the non-private function > and variable names that were present in the latest Org stable > release must be either su

Re: [PATCH] ob-shell: consistent prefix

2024-01-16 Thread Ihor Radchenko
Matt writes: > The attached patch makes names in ob-shell.el use the same prefix > "org-babel-shell-" (along with a few similar minor consistency > updates). > > Without the patch, three naming conventions exist: > > - org-babel-shell > - org-babel-sh > - ob-shell <- that's my fault :) > ...

[PATCH] ob-shell: consistent prefix

2024-01-15 Thread Matt
The attached patch makes names in ob-shell.el use the same prefix "org-babel-shell-" (along with a few similar minor consistency updates). Without the patch, three naming conventions exist: - org-babel-shell - org-babel-sh - ob-shell <- that's my fault :) The Org Babel shell library was prev