Re: [PATCH] ob-python: Fix async evaluation

2023-07-13 Thread Jack Kamm
Liu Hui writes: > Thanks for pointing out the problem! I find the problem disappears > after removing the `run-python` line, and I have updated the patch > accordingly. Thank you. I applied your patch to main branch. I am curious why the previous version of your test was causing hanging -- whet

Re: [PATCH] ob-python: Fix async evaluation

2023-07-13 Thread Liu Hui
. From 4c552eb4eec5d84727775645cdf41acebd7fd1da Mon Sep 17 00:00:00 2001 From: Liu Hui Date: Wed, 12 Jul 2023 18:07:06 +0800 Subject: [PATCH] ob-python: Fix async evaluation * lisp/ob-python.el (org-babel-python-async-evaluate-session): Bind `python-shell-buffer-name' inside the temp buffer. * testing/l

Re: [PATCH] ob-python: Fix async evaluation

2023-07-12 Thread Jack Kamm
Liu Hui writes: > OK, I have added a test to the patch. While your test works on its own, it seems to break subsequent tests (the next test hangs). My guess is that it has something to do with the fact that most of the Python session tests share the same session, and ob-python is getting confus

Re: [PATCH] ob-python: Fix async evaluation

2023-07-12 Thread Liu Hui
Date: Wed, 12 Jul 2023 18:07:06 +0800 Subject: [PATCH] ob-python: Fix async evaluation * lisp/ob-python.el (org-babel-python-async-evaluate-session): Bind `python-shell-buffer-name' inside the temp buffer. * testing/lisp/test-ob-python.el (test-ob-python/async-local-python-shell): Add test. -

Re: [PATCH] ob-python: Fix async evaluation

2023-07-11 Thread Jack Kamm
Ihor Radchenko writes: > Liu Hui writes: > >> To reproduce the bug: >> >> 1. create test.org: >> ──✀── >> #+begin_src python :session "*Python 3*" :async t >> 1 >> #+end_src >> >> # Local Variables: >> # python-shell-buffer-name: "Python 3" >> # End: >> ──

Re: [PATCH] ob-python: Fix async evaluation

2023-07-11 Thread Ihor Radchenko
Liu Hui writes: > To reproduce the bug: > > 1. create test.org: > ──✀── > #+begin_src python :session "*Python 3*" :async t > 1 > #+end_src > > # Local Variables: > # python-shell-buffer-name: "Python 3" > # End: > ──✀── > > 2. emacs

[PATCH] ob-python: Fix async evaluation

2023-07-10 Thread Liu Hui
d97895c00f38d466 Mon Sep 17 00:00:00 2001 From: Liu Hui Date: Tue, 11 Jul 2023 10:49:07 +0800 Subject: [PATCH] ob-python: Fix async evaluation * lisp/ob-python.el (org-babel-python-async-evaluate-session): Bind `python-shell-buffer-name' inside the temp buffer. --- lisp/ob-python.el | 47 +++