Re: [PATCH] ob-java, a proposal on import improvement

This was not marked as applied on updates.orgmode.org. Doing so with the X-Woof-Patch header. ian martins writes: > It's no problem. Didn't mean to rush you. Thanks again for the patch. Applied.

Re: [PATCH] ob-java, a proposal on import improvement

It's no problem. Didn't mean to rush you. Thanks again for the patch. Applied. On Sat, Jan 16, 2021 at 10:32 AM John Herrlin wrote: > > > Sorry for latency, 9to5 been killing it. Thx for the feedback, make > sense! Here is a new patch with the improvements. > > > > ian martins writes: > > > John

Re: [PATCH] ob-java, a proposal on import improvement

Sorry for latency, 9to5 been killing it. Thx for the feedback, make sense! Here is a new patch with the improvements. >From 680e04217c8e4c536875379cac01edccd694c4cb Mon Sep 17 00:00:00 2001 From: John Herrlin Date: Sun, 10 Jan 2021 21:47:26 +0100 Subject: [PATCH] ob-java: Include static imports

Re: [PATCH] ob-java, a proposal on import improvement

John, would you mind if I go ahead and make the change I mentioned and push it with you as the author? On Tue, Jan 12, 2021 at 7:00 AM ian martins wrote: > > On Sun, Jan 10, 2021 at 3:55 PM John Herrlin wrote: > > ian martins writes: > > > I think the problem was that I was missing static > > >

Re: [PATCH] ob-java, a proposal on import improvement

On Sun, Jan 10, 2021 at 3:55 PM John Herrlin wrote: > ian martins writes: > > I think the problem was that I was missing static > > imports, which you fixed in the first chunk of your patch. I don't > > think the rest of the change is

Re: [PATCH] ob-java, a proposal on import improvement

ian martins writes: > On Fri, Jan 8, 2021 at 11:28 AM John Herrlin wrote: > >> I would like to combine imports from header-args with imports from a >> source block. >> ... >> I didnt get the to work so I made a patch. > > John, Sorry that wasn't working. Thanks for investigating and > submittin

Re: [PATCH] ob-java, a proposal on import improvement

> I can’t give an informed opinion about the patch, but the example looks > great! I did not know that Java support in org-babel is that good. Thanks. Yes, ob-java got an update with org 9.4.

Re: [PATCH] ob-java, a proposal on import improvement

On Fri, Jan 8, 2021 at 11:28 AM John Herrlin wrote: > I would like to combine imports from header-args with imports from a > source block. > ... > I didnt get the to work so I made a patch. John, Sorry that wasn't working. Thanks for investigating and submitting a fix. I think the problem was t

Re: [PATCH] ob-java, a proposal on import improvement

John Herrlin writes: > I would like to combine imports from header-args with imports from a > source block. > > Here is an example: > > * RxJava > :PROPERTIES: > :header-args: :dir src :results output code > :header-args:java: :cmdline -classpath ./rxjava-1.3.8.jar:src:. :cmpflag > -c

[PATCH] ob-java, a proposal on import improvement

Hey, Happy new year and a good continuation! I would like to combine imports from header-args with imports from a source block. Here is an example: * RxJava :PROPERTIES: :header-args: :dir src :results output code :header-args:java: :cmdline -classpath ./rxjava-1.3.8.jar:src:. :cmpf