Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-12-27 Thread Ihor Radchenko
Ihor Radchenko writes: > Also, several small comments about the commit message. For the record, an amended version of this patch have been applied. See https://orgmode.org/list/87leona2r1.fsf@localhost -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle

2022-11-06 Thread Ihor Radchenko
Daniel Ziltener writes: > This patch adds the "strip-tangle" option for the :noweb header > argument. This strips the noweb tags before tangling the block. This can > be useful for e.g. testing purposes where one wants to use a block as > test case that can be both run inline as well as tangled

[PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle

2022-11-06 Thread Daniel Ziltener
* lisp/ob-tangle.el (org-babel-tangle-single-block): strip noweb tags from block if :noweb has been set to strip-tangle. * lisp/ob-core.el (org-babel-common-header-args-w-values): add "strip-tangle" as new allowed value. * lisp/ob-core.el (org-babel-noweb-p): add "strip-tangle" at the appropriate p

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-11-01 Thread Ihor Radchenko
Daniel Ziltener writes: >> Could you please create a separate patch file and attach it in the >> reply? > Sure, here's the patch attached, as generated by "git format-patch > origin/main". Thanks! I tried to apply your patch and run tests. The new test for "strip-tangle" is failing on my side.

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-30 Thread Timothy
Hi Ihor, > #+name: setup > #+begin_src bash > > cd /path/to/tests > #+end_src > > #+begin_src bash :noweb strip-tangle > > make test1 > #+end_src > > #+begin_src bash :noweb strip-tangle > > make test2 > #+end_src > > Then, one can interactively run individual tests from Org and then > tangle th

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-30 Thread Ihor Radchenko
Timothy writes: > Hi Daniel, > >> Add a “strip-tangle” noweb option to strip the noweb tags when tangling, but >> keep and expand them otherwise. > > I must admit I can’t see the point of this — would you mind providing an > example of when this would be useful? #+name: setup #+begin_src bash cd

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-30 Thread Daniel Ziltener
00 2001 From: Daniel Ziltener Date: Sun, 30 Oct 2022 01:20:53 +0200 Subject: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle * lisp/ob-tangle.el (org-babel-tangle-single-block): strip noweb tags from block if :noweb has been set to strip-tangle. * lisp/ob-core.el (org-babel-commo

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-29 Thread Timothy
Hi Daniel, > Add a “strip-tangle” noweb option to strip the noweb tags when tangling, but > keep and expand them otherwise. I must admit I can’t see the point of this — would you mind providing an example of when this would be useful? All the best, Timothy -- Timothy (‘tecosaur’/‘TEC’), Org mo

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-29 Thread Ihor Radchenko
Daniel Ziltener writes: > From: Daniel Ziltener > > * lisp/ob-tangle.el (org-babel-tangle-single-block): strip noweb tags > from block if :noweb has been set to strip-tangle. > * lisp/ob-core.el (org-babel-common-header-args-w-values): add > "strip-tangle" as new allowed value. > * testing/lisp/

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-29 Thread Daniel Ziltener
From: Daniel Ziltener * lisp/ob-tangle.el (org-babel-tangle-single-block): strip noweb tags from block if :noweb has been set to strip-tangle. * lisp/ob-core.el (org-babel-common-header-args-w-values): add "strip-tangle" as new allowed value. * testing/lisp/test-ob-tangle.el (ob-tangle/strip-tan

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-28 Thread Ihor Radchenko
Daniel Ziltener writes: >> Could you please follow >> https://orgmode.org/worg/org-contribute.html#commit-messages for the >> commit log entries? > I tried to follow that. To follow it "more" I guess I have to make one > commit per file I changed? There isn't an example for multiple files, so >

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-28 Thread Daniel Ziltener
Am 28.10.22 um 04:19 schrieb Ihor Radchenko: dzilte...@lyrion.ch writes: From: Daniel Ziltener * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a "strip-tangle" noweb option to strip the noweb tags when tangling, but keep and expand them otherwise. Thanks for the patch! If

Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-27 Thread Ihor Radchenko
dzilte...@lyrion.ch writes: > From: Daniel Ziltener > > * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a > "strip-tangle" noweb option to strip the noweb tags when tangling, but > keep and expand them otherwise. Thanks for the patch! If I understand correctly, you are sugges

[PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

2022-10-26 Thread dziltener
From: Daniel Ziltener * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a "strip-tangle" noweb option to strip the noweb tags when tangling, but keep and expand them otherwise. --- doc/org-manual.org | 6 ++ lisp/ob-core.el| 6 +++--- lisp/ob-ta