Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

On Sun, 17 Mar 2024 17:26:48 +0100 Max Nikulin wrote --- > On 17/03/2024 20:42, Matt wrote: > > On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > > > > > > (1) revert the commit; (2) re-apply the > > > commit version with the correct author attribution. >

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

On 17/03/2024 20:42, Matt wrote: On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > > (1) revert the commit; (2) re-apply the > commit version with the correct author attribution. Done. 1. git revert 2. make changes (e.g. emacs followed by *type-type-type* or some i

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

Matt writes: > > We should avoid force pushing unless something is terribly broken. > > What you may do instead is (1) revert the commit; (2) re-apply the > > commit version with the correct author attribution. > > Done. > ... > I added a little section within copyright: > https://git.sr.ht/~

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > Matt m...@excalamus.com> writes: > > > First, would you like me to update the commit? If so, I will need > > guidance. The correct procedure to change the author after committing to > > remote is unclear to me. I wou

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

Matt writes: > > For future, we prefer keeping the original commit author in the "author" > > field of the commits - this is important to keep track of the number of > > changed lines for contributors without FSF copyright assignment. > > Thank you for letting me know this is an issue. > > F

How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

On Sat, 16 Mar 2024 11:11:38 +0100 Ihor Radchenko wrote --- > I notice that you changed the commit author and only referenced Aaron in > Submitted By: metadata. > > For future, we prefer keeping the original commit author in the "author" > field of the commits - this is important to

Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name

Matt writes: > Finally had time to commit it. > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0e2a9524dc6da8b4d60672e85aba74076baac211 Thanks! I notice that you changed the commit author and only referenced Aaron in Submitted By: metadata. For future, we prefer keeping the

Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name

Thanks for the merge! On Fri, Mar 15, 2024, at 17:38, Matt wrote: > Finally had time to commit it. > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0e2a9524dc6da8b4d60672e85aba74076baac211 > > Nice catch and thanks for your contribution! > > -- > Matt Trzcinski > Emacs Org cont

Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name

Finally had time to commit it. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0e2a9524dc6da8b4d60672e85aba74076baac211 Nice catch and thanks for your contribution! -- Matt Trzcinski Emacs Org contributor (ob-shell) Learn more about Org mode at https://orgmode.org Support Org de

Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name

Matt writes: > Thank you for your report and the patch. Matthew, you are free to apply patches relevant to ob-shell to savannah repository, if you think that they are fine. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org de

Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name

On Mon, 11 Mar 2024 06:12:47 +0100 Aaron L. Zeng wrote --- > * lisp/ob-shell.el (org-babel-shell-initialize): Override > explicit-shell-file-name in addition to shell-file-name. > > When a session with shell source blocks, execution calls `shell', > which checks `explicit-shell-fil

[PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name

* lisp/ob-shell.el (org-babel-shell-initialize): Override explicit-shell-file-name in addition to shell-file-name. When a session with shell source blocks, execution calls `shell', which checks `explicit-shell-file-name' variable before `shell-file-name', to determine what shell to run. If the us