Re: [PATCH] Unindentation fixup for code blocks

2024-03-12 Thread Ihor Radchenko
Ihor Radchenko writes: > I am attaching an amended patch with modified commit message and > docstring describing the invisible text is accounted as visible. > I also added TINYCHANGE cookie as you do not appear to have FSF > copyright assignment. Applied, onto main. https://git.savannah.gnu.org/

Re: [PATCH] Unindentation fixup for code blocks

2024-01-21 Thread Ihor Radchenko
Ihor Radchenko writes: > Thanks! This patch does apply. > I am not yet sure if I like this patch or the previous one more. I am > thinking about combining them and implementing something like > `org-move-to-text-column'. I do not see immediate use of `org-move-to-text-column', so let's keep thin

Re: [PATCH] Unindentation fixup for code blocks

2024-01-10 Thread Ihor Radchenko
Psionic K writes: >> Would you also be able to create a reproducer, so that we can replicate > the problem and write a test? > > Yeah, I just have to make some indentation text invisible. Where > should such a test live? Where is your documentation on running a > test? The tests live in tests/

Re: [PATCH] Unindentation fixup for code blocks

2024-01-10 Thread Psionic K
> Would you also be able to create a reproducer, so that we can replicate the problem and write a test? Yeah, I just have to make some indentation text invisible. Where should such a test live? Where is your documentation on running a test? > It looks like you did not send the patch with git se

Re: [PATCH] Unindentation fixup for code blocks

2024-01-10 Thread Ihor Radchenko
Psionic K writes: > When cleaning up hard indentation, I found my source blocks remaining > indented. > > The way that org-do-remove-indentation is sensitive to invisible text. > This occurs for source blocks whenever using org-modern-mode, where it > makes the source blocks align left. Thanks

[PATCH] Unindentation fixup for code blocks

2024-01-10 Thread Psionic K
When cleaning up hard indentation, I found my source blocks remaining indented. The way that org-do-remove-indentation is sensitive to invisible text. This occurs for source blocks whenever using org-modern-mode, where it makes the source blocks align left. By swapping out the arithmetic and expr