Re: [PATCH] Omit file description when :file-desc has nil value

Matt Huszagh writes: > I've made those fixes and attached the updated patch. Applied (d9884cfa7). Thank you!

Re: [PATCH] Omit file description when :file-desc has nil value

Kyle Meyer writes: > So, with the typo/spurious space change clean-ups, this looks good to > me. IIRC from a previous thread, you haven't yet completed the > copyright paperwork. Is that the case? I've made those fixes and attached the updated patch. I also sent you the paperwork separately (

Re: [PATCH] Omit file description when :file-desc has nil value

Matt Huszagh writes: > Subject: [PATCH] list/ob-core.el: Allow passing empty vector to :file-desc to > omit description s/list/lisp/ > diff --git a/doc/org-manual.org b/doc/org-manual.org > index e7d25b90e..a790f3225 100644 > --- a/doc/org-manual.org > +++ b/doc/org-manual.org > @@ -17482,10 +1

Re: [PATCH] Omit file description when :file-desc has nil value

Kyle Meyer writes: > I'd be happy for you to take what I sent and work it into a proper > patch. Here are some other loose ends in addition to the manual update > you mentioned: > > * a NEWS entry for 9.5 > > * decide whether (:file-desc . []) should be handled explicitly rather > than t

Re: [PATCH] Omit file description when :file-desc has nil value

Matt Huszagh writes: > This patch looks good. I've tested it and it works well for me. Thanks > for coming up with a good solution! Thanks for testing it out. > I think the one thing still missing is some documentation in the info > manual. Something along the lines of [...] Yep, the manual sho

Re: [PATCH] Omit file description when :file-desc has nil value

Kyle Meyer writes: > But it's not a direct comparison against that use case and the use case > you want to support. The potential breakage of existing documents is a > big factor to go against. Yep, I agree. I think my phrasing could have just been better. I meant to include the breakage as a f

Re: [PATCH] Omit file description when :file-desc has nil value

Matt Huszagh writes: >> Kyle Meyer writes: >> >>> I also don't find the current behavior particularly intuitive. (I'm >>> also not really a babel user, so my opinion probably shouldn't count for >>> much.) If we were adding it today, I think what you describe would be >>> better, but, as you me

Re: [PATCH] Omit file description when :file-desc has nil value

> Kyle Meyer writes: > >> I also don't find the current behavior particularly intuitive. (I'm >> also not really a babel user, so my opinion probably shouldn't count for >> much.) If we were adding it today, I think what you describe would be >> better, but, as you mention, breakage also now als

Re: [PATCH] Omit file description when :file-desc has nil value

Kyle Meyer writes: > I also don't find the current behavior particularly intuitive. (I'm > also not really a babel user, so my opinion probably shouldn't count for > much.) If we were adding it today, I think what you describe would be > better, but, as you mention, breakage also now also weigh

Re: [PATCH] Omit file description when :file-desc has nil value

Hi Matt, It looks like this message got detached from the original thread [*] and ended up a bit misformatted (at least for plain-text readers). This seems to be the message you accidentally sent to me off-list, so I will copy my reply here as well. [*] https://orgmode.org/list/87tuwef76g@

[PATCH] Omit file description when :file-desc has nil value

Kyle Meyer mailto:k...@kyleam.com)> writes: > A use case was given in the initial patch: > . > The test for this behavior mentioned there is > test-ob/file-desc-header-argument. > > That th

Re: [PATCH] Omit file description when :file-desc has nil value

Matt Huszagh writes: > Hello, > > This patch omits a file description when :file-desc has a nil > value. Previously, the following src block > > #+BEGIN_SRC asymptote :results value file :file circle.pdf :file-desc > :output-dir img/ > size(2cm); > draw(unitcircle); > #+END_SRC > > would yiel

Re: [PATCH] Omit file description when :file-desc has nil value

Matt Huszagh writes: > This patch omits a file description when :file-desc has a nil > value. I've modified the patch to yield the same effect when executing a source block. Matt >From 24d156e421973b5a97f1c797d48f1daa95348898 Mon Sep 17 00:00:00 2001 From: Matt Huszagh Date: Wed, 2 Sep 2020 2

[PATCH] Omit file description when :file-desc has nil value

Hello, This patch omits a file description when :file-desc has a nil value. Previously, the following src block #+BEGIN_SRC asymptote :results value file :file circle.pdf :file-desc :output-dir img/ size(2cm); draw(unitcircle); #+END_SRC would yield #+RESULTS: [[file:img/circle.pdf][circle