Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2020-02-12 Thread Bastien
Hi Tom, Tom Gillespie writes: > An unrelated question. > > I've written some basic tests for this and I couldn't find any other > tests that seemed to deal with fontification at all. In order to get > fontification tests to work I added a call to `font-lock-ensure' inside > `org-test-with-temp-t

Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-28 Thread Bastien
Hi Tom and Nicolas, just a heads up on this thread to confirm that Tom assignment has been registered by the FSF on Dec. 23rd, so the patch is included in 9.3.1. Thanks again for the patch, Tom. Best, -- Bastien

Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-19 Thread Nicolas Goaziou
Hello, Tom Gillespie writes: > Subject: org.el: Fix verbatim block fontification to end blocks on > headlines Applied. Thank you. I added TINYCHANGE cookie at the end of your commit message since I do not know if you have signed FSF papers already. If you did, please let me know so I can recor

Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-17 Thread Tom Gillespie
Hi, Here is the updated patch, including the fix to only trigger on actual headlines (and not bold or similar), the readability improvement for beg-of-next-line and a fix to call point-max only once per branch. I also switched all the regex over to use the rx macro. I left out the tests because

Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-14 Thread Nicolas Goaziou
Hello, Tom Gillespie writes: > I've written some basic tests for this and I couldn't find any other > tests that seemed to deal with fontification at all. In order to get > fontification tests to work I added a call to `font-lock-ensure' inside > `org-test-with-temp-text' (see excerpted patch bi

Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-13 Thread Tom Gillespie
Adam Porter writes: > May I recommend using the rx macro for regexps? They are much easier > for humans to parse, which helps reduce errors like the ones mentioned > here. And they are about to gain some very useful new features > in Emacs 27. Yep. I'll switch the regex in over to use rx. An

Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-12 Thread Adam Porter
May I recommend using the rx macro for regexps? They are much easier for humans to parse, which helps reduce errors like the ones mentioned here. And they are about to gain some very useful new features in Emacs 27.

Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-12 Thread Tom Gillespie
Thank you very much for the feedback. I will make the additional fixes against maint along with the changes for clarity and send them along tomorrow. Additional replies in line. Best, Tom On Thu, Dec 12, 2019 at 12:40 AM Nicolas Goaziou wrote: > > Hello, > > Tom Gillespie writes: > > > This patc

Re: [PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-12 Thread Nicolas Goaziou
Hello, Tom Gillespie writes: > This patch is a change to how org fontifies verbatim source blocks re: [1]. > Hopefully it answers Nicolas's question from that thread. Best! OK. Now I see what you meant. Thank you. > (when (re-search-forward > - (concat "^[ \t]*#\\+end" (ma

[PATCH] Fix verbatim block fontification to end blocks on headlines

2019-12-11 Thread Tom Gillespie
This patch is a change to how org fontifies verbatim source blocks re: [1]. Hopefully it answers Nicolas's question from that thread. Best! Tom On Sun, Dec 8, 2019 at 12:05 AM Nicolas Goaziou wrote: > I do not understand. Source and example blocks are verbatim blocks, > whereas verse blocks are n