Hi Bastien,
Bastien writes:
> Thanks a lot! Nitpicking, there is this new warning:
>
> In toplevel form:
> ob-python.el:309:1: Warning: Unused lexical variable ‘last-indent’
>
> Can you fix it?
Oops, sorry for letting that slip through, and t
Hi Jack,
Jack Kamm writes:
> Kyle Meyer writes:
>
>>> I'd like to do the honors of making my first push to the repo :) So
>>> please let me know if you're fine with me to proceed.
>> All good from my end :>
>
> Thanks -- I've pushed to master :D
Thanks a lot! Nitpicking, there is this new war
Kyle Meyer writes:
>> I'd like to do the honors of making my first push to the repo :) So
>> please let me know if you're fine with me to proceed.
> All good from my end :>
Thanks -- I've pushed to master :D
Jack Kamm writes:
> Hi Kyle,
>
> Thanks for the thorough review as always. An updated patch incorporating
> your feedback is at the end of this email.
Thanks for the updates.
> I'd like to do the honors of making my first push to the repo :) So
> please let me know if you're fine with me to pro
Hi Kyle,
Thanks for the thorough review as always. An updated patch incorporating
your feedback is at the end of this email.
I'd like to do the honors of making my first push to the repo :) So
please let me know if you're fine with me to proceed. Or, if you have
more comments, they are always app
Hi Jack,
Thanks again for the patch. Testing it out a bit, your ast-based
approach seems to work nicely.
Jack Kamm writes:
> Subject: [PATCH] ob-python: Fix several issues with :session :results value
>
> * lisp/ob-python.el (org-babel-python-evaluate-session): Fix a few
> related issues with
Jack Kamm writes:
> [...]
> I've checked this patch works for both Python2 and Python3, as well as
> for IPython.
Currently, i'm learning both elisp and python. Thanks for good patchs^^^
Sincerely, Byung-Hee
--
^고맙습니다 _地平天成_ 감사합니다_^))//
Hi Jack,
Jack Kamm writes:
> Sure, I would be interested in this, if it's helpful.
It is for sure! Thanks for accepting.
> I need an account for code.orgmode.org, and whatever commit permissions
> you think appropriate.
Please send me a private message with your prefered username and I
will
> thanks for your patch - Kyle is on it, but IIRC we do not have a
> maintainer for the ob-python.el file.
>
> Would you like to take this in charge? Or someone else?
Sure, I would be interested in this, if it's helpful.
I need an account for code.orgmode.org, and whatever commit permissions
you
Hi Jack,
thanks for your patch - Kyle is on it, but IIRC we do not have a
maintainer for the ob-python.el file.
Would you like to take this in charge? Or someone else?
Thanks,
--
Bastien
Thanks Kyle! I've slightly updated the patch, because I had neglected to
handle Python exceptions. If you haven't started yet, please consider
the updated patch instead (it only differs by a few lines within
org-babel-python--eval-tmpfile).
>From c2fff65f36141b78d91af9d6264d0f936ee5a3a1 Mon Sep 17
Jack Kamm writes:
> This patch fixes several related issues with python blocks with
> parameters ":session :results value", including:
>
> - Broken if-else and try-except statements.
> - Correctly parsing blank lines in indented blocks.
> - Returning the correct value when the underscore "_" vari
This patch fixes several related issues with python blocks with
parameters ":session :results value", including:
- Broken if-else and try-except statements.
- Correctly parsing blank lines in indented blocks.
- Returning the correct value when the underscore "_" variable
has been assigned.
It w
13 matches
Mail list logo
