Re: [PATCH] Fix ox-icalendar export of diary timestamps

2025-01-19 Thread Jack Kamm
Ihor Radchenko writes: >> +To export active timestamps only without diary timestamps, users can >> +set ~org-export-with-timestamps~ and ~org-icalendar-with-timestamps~ >> +to ~active-exclude-diary~. > > Maybe you can emphasize more that "without diary timestamp" is the old > behavior. We often u

Re: [PATCH] Fix ox-icalendar export of diary timestamps

2025-01-13 Thread Ihor Radchenko
Jack Kamm writes: > Unfortunately I found a case in the wild where this change caused a > temporary problem in org-caldav: > https://github.com/dengste/org-caldav/issues/315 > ... > I attach a patch to do this, by adding an option `active-exclude-diary' > for `org-icalendar-with-timestamps' and `

Re: [PATCH] Fix ox-icalendar export of diary timestamps

2025-01-12 Thread Jack Kamm
Ihor Radchenko writes: > Jack Kamm writes: > >> Ihor Radchenko writes: >> >>> I agree that it makes sense. >>> However, it is technically a breaking change. >>> May you please add a news entry as well? >> >> Thanks, I've updated the patch with a news entry now. > > Thanks! > Applied, onto main.

Re: [PATCH] Fix ox-icalendar export of diary timestamps

2024-09-22 Thread Ihor Radchenko
Jack Kamm writes: > Ihor Radchenko writes: > >> I agree that it makes sense. >> However, it is technically a breaking change. >> May you please add a news entry as well? > > Thanks, I've updated the patch with a news entry now. Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs

Re: [PATCH] Fix ox-icalendar export of diary timestamps

2024-09-21 Thread Jack Kamm
Ihor Radchenko writes: > I agree that it makes sense. > However, it is technically a breaking change. > May you please add a news entry as well? Thanks, I've updated the patch with a news entry now. >From 5c40741664402a5984803dc3de452ea949885887 Mon Sep 17 00:00:00 2001 From: Jack Kamm Date: S

Re: [PATCH] Fix ox-icalendar export of diary timestamps

2024-09-21 Thread Ihor Radchenko
Jack Kamm writes: > ox-icalendar skips the following event with a diary timestamp during > export: > > * First Sunday of the month > <%%(diary-float t 0 1)> > > ox-icalendar actually has longstanding code to handle diary timestamps > [1], but that code path is not reached, in part because > `

[PATCH] Fix ox-icalendar export of diary timestamps

2024-09-14 Thread Jack Kamm
ox-icalendar skips the following event with a diary timestamp during export: * First Sunday of the month <%%(diary-float t 0 1)> ox-icalendar actually has longstanding code to handle diary timestamps [1], but that code path is not reached, in part because `org-export--skip-p' always skips tim