Re: [PATCH] Ability to specify :html-head as a function

2024-07-07 Thread Ihor Radchenko
Nathan Nichols writes: > OK, I fixed the commit message and other issues that you mentioned. Please > let me know if theres anything else. Thanks! Applied, onto main, with changes. I changed the commit message to list all the changes in all the functions, not just per-file. I also added TINYCH

Re: [PATCH] Ability to specify :html-head as a function

2024-07-07 Thread Nathan Nichols
OK, I fixed the commit message and other issues that you mentioned. Please let me know if theres anything else. On Tue, Jul 2, 2024 at 7:58 AM Ihor Radchenko wrote: > Nathan Nichols writes: > > > Ok here's an updated patch. Please let me know if there's anything else. > > Thanks! > > > Subject:

Re: [PATCH] Ability to specify :html-head as a function

2024-07-02 Thread Ihor Radchenko
Nathan Nichols writes: > Ok here's an updated patch. Please let me know if there's anything else. Thanks! > Subject: [PATCH] Added ability to specify :html-head as a string or function Please add changelog to the commit message. See https://orgmode.org/worg/org-contribute.html#commit-messages

Re: [PATCH] Ability to specify :html-head as a function

2024-06-30 Thread Nathan Nichols
Ok here's an updated patch. Please let me know if there's anything else. On Sun, Jun 30, 2024 at 4:30 AM Rudolf Adamkovič wrote: > Nathan Nichols writes: > > > +(defun org-html-normalize-str-or-fn (input &rest args) > > How about > > org-html-normalize-string-or-function > > instead of > >

Re: [PATCH] Ability to specify :html-head as a function

2024-06-30 Thread Rudolf Adamkovič
Nathan Nichols writes: > +(defun org-html-normalize-str-or-fn (input &rest args) How about org-html-normalize-string-or-function instead of org-html-normalize-str-or-fn to match org-element-normalize-string and make searching easier? Rudy -- "Great minds discuss ideas; average mind

Re: [PATCH] Ability to specify :html-head as a function

2024-06-29 Thread Nathan Nichols
Ok, here's a patch. Please let me know if this is acceptable or not. On Sat, Jun 22, 2024 at 8:33 AM Ihor Radchenko wrote: > Nathan Nichols writes: > > >> This looks like a copy-paste of `org-element-normalize-string'. > >> Why not simply calling `org-element-normalize-string'? > > > > I change

Re: [PATCH] Ability to specify :html-head as a function

2024-06-22 Thread Ihor Radchenko
Nathan Nichols writes: >> This looks like a copy-paste of `org-element-normalize-string'. >> Why not simply calling `org-element-normalize-string'? > > I changed it at one point, but then changed it back and didn't realize that > it was ultimately unchanged. > Here's a patch that uses `org-elemen

Re: [PATCH] Ability to specify :html-head as a function

2024-06-21 Thread Nathan Nichols
> This looks like a copy-paste of `org-element-normalize-string'. > Why not simply calling `org-element-normalize-string'? I changed it at one point, but then changed it back and didn't realize that it was ultimately unchanged. Here's a patch that uses `org-element-normalize-string` instead. > Al

Re: [PATCH] Ability to specify :html-head as a function

2024-05-13 Thread Ihor Radchenko
Nathan Nichols writes: > Here's a patch that adds the ability to specify :html-head as a function. I > think this is a logical change because: > > 1. It provides a wider range of options for how to use :html-head (before > :html-head could only be a string, now it can also be a function.) > 2. I

[PATCH] Ability to specify :html-head as a function

2024-05-13 Thread Nathan Nichols
Hello org-mode users, Here's a patch that adds the ability to specify :html-head as a function. I think this is a logical change because: 1. It provides a wider range of options for how to use :html-head (before :html-head could only be a string, now it can also be a function.) 2. It is consisten