Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-09-07 Thread Suhail Singh
Ihor Radchenko writes: >>> From a feasibility perspective, I suspect it might be better for you (or >>> someone else who's signed the FSF copyright assignment paperwork) to >>> take on the work of applying changes that are similar in spirit to the >>> patch. >> >> I was checking up to see what th

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-09-07 Thread Ihor Radchenko
Suhail Singh writes: >> From a feasibility perspective, I suspect it might be better for you (or >> someone else who's signed the FSF copyright assignment paperwork) to >> take on the work of applying changes that are similar in spirit to the >> patch. > > I was checking up to see what the curren

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-09-02 Thread Suhail Singh
Suhail Singh writes: > Ihor Radchenko writes: > >> Next, if you are not interested in adding :textarea support, it is >> OK. Adding #+ATTR_HTML support for code blocks and fixed width elements >> will still be a welcome improvement (I was just hoping to push you to >> contribute a bit more ;)) >

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-22 Thread Suhail Singh
Ihor Radchenko writes: > Commits under similar names are: > > Suhail 96eb9f0b4 * piem/s/org-lint-add-function-to-removeJun6 org-lint: Add > function to remove checker(s) > ... > > I assume that 96eb9f0b4 is yours. > It has 9 LOC. Yes. > ~6LOC remaining until aproximate 15LOC limit we can accep

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-22 Thread Ihor Radchenko
Suhail Singh writes: > Given that I already have some contributions in Org mode and I don't, at > present, intend to do the copyright assignment to FSF, could you please > confirm: > > 1. How many lines worth of changes I can still introduce without going >over the limit? I do not see any co

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-22 Thread Suhail Singh
Ihor Radchenko writes: > AFAIU, your main point is that you want the patch to land on bugfix. It > will not, regardless whether we add :textarea support or not. While not the answer I had hoped for, I appreciate the clarification. > Next, if you are not interested in adding :textarea support, i

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-22 Thread Ihor Radchenko
Suhail Singh writes: >> So, if we start allowing arbitrary attributes in more blocks, may as >> well include specially handled attributes like :textarea. > > Yes, it is possible to address my concern while also extending support > for non-HTML attributes like :textarea. However, they still are >

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-22 Thread Suhail Singh
Ihor Radchenko writes: > Your request, in its core, is asking to make treatment of verbatim > blocks more regular in ox-html. I would phrase it differently. Just to be clear, my concern isn't simply "verbatim blocks", and it isn't simply to make handling "more regular". Apologies for the innac

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-22 Thread Ihor Radchenko
Suhail Singh writes: >> Please address my concern about :textarea attribute. I do not see why >> we should ignore it here. > > I don't understand your concern. Could you please elaborate on what you > mean by "why we should ignore it here"? What is the "it" and what is > the "here"? Your reque

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-22 Thread Suhail Singh
Ihor Radchenko writes: > Please address my concern about :textarea attribute. I do not see why > we should ignore it here. I don't understand your concern. Could you please elaborate on what you mean by "why we should ignore it here"? What is the "it" and what is the "here"? >From your email

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-22 Thread Ihor Radchenko
Suhail Singh writes: >>> The attached patches are a straight-forward copy-paste of relevant code >>> from org-html-example-block. It may be better to refactor this logic >>> and ensure that it is applied on all relevant AST nodes (others are >>> probably affected as well). >> >> Sounds reasonabl

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-07-19 Thread Suhail Singh
Ihor Radchenko writes: >> Unlike example blocks, source code and fixed-width blocks don't support >> the attr_html keyword. Contrast these outputs: >> ... >> The attached patches are a straight-forward copy-paste of relevant code >> from org-html-example-block. It may be better to refactor this

Re: [PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-06-18 Thread Ihor Radchenko
Suhail Singh writes: > Unlike example blocks, source code and fixed-width blocks don't support > the attr_html keyword. Contrast these outputs: > ... > The attached patches are a straight-forward copy-paste of relevant code > from org-html-example-block. It may be better to refactor this logic

[PATCH] [BUG] Support attr_html in source code and fixed-width blocks

2024-06-17 Thread Suhail Singh
Unlike example blocks, source code and fixed-width blocks don't support the attr_html keyword. Contrast these outputs: #+begin_src emacs-lisp :results value replace :wrap src html (require 'org) (require 'ox-html) (org-export-string-as "#+attr_html: :class foo ,#+begin_src sh :exports