Re: [PATCH] (v2) New LaTeX code export option: engraved

2022-05-11 Thread Ihor Radchenko
Timothy writes: Thanks for the replies. I consider all but one as resolved. >> What will happen if there is no [LISTINGS-SETUP]? > > Captioned/Floating code blocks won’t work. Can you also add this to the documentation of the preamble variable? Otherwise, it may not be very clear what inclusion

Re: [PATCH] (v2) New LaTeX code export option: engraved

2022-05-10 Thread Max Nikulin
On 09/05/2022 19:57, Timothy wrote: Before merging, could you also try to implement tests at least for engraved feature? If I recall correctly, we do not currently have backend-specific tests. But it would certainly help if we did. You might as well write a small “nucleus” test for ox-latex.

Re: [PATCH] (v2) New LaTeX code export option: engraved

2022-05-09 Thread Timothy
Hi Ihor, > Before merging, could you also try to implement tests at least for > engraved feature? If I recall correctly, we do not currently have > backend-specific tests. But it would certainly help if we did. You might > as well write a small “nucleus” test for ox-latex. Probably not a bad idea

Re: [PATCH] (v2) New LaTeX code export option: engraved

2022-05-08 Thread Ihor Radchenko
Timothy writes: > I have a new set of patches (attached), which make use of a major new feature > in > engrave-faces v0.3: engraved themes. Thanks! > Glad to hear you’ve been able to have a look over the patches. With the > feedback > I’ve received here so far, if no issues come up in the nex

Re: [PATCH] (v2) New LaTeX code export option: engraved

2022-05-08 Thread Timothy
Hi Daniel & co., I have a new set of patches (attached), which make use of a major new feature in engrave-faces v0.3: engraved themes. Now, the theme used for source blocks can be set by the document keyword `#+latex_engraved_theme: THEME-NAME'. Furthermore, the theme can be customised on a per-