Re: [Orgmode] Re: PATCH: proposed improvements to org-src-mode

2009-09-06 Thread Carsten Dominik
Hi Dan, thanks for doing such a careful job. I applied all three parts. - Carsten On Sep 5, 2009, at 7:33 PM, Dan Davison wrote: Carsten Dominik writes: Hi Dan, OK, I have now applied the patch. If you don't mind, could you please double-check the commit? [Re.: commit 4b6988bf36cb458c

Re: [Orgmode] Re: PATCH: proposed improvements to org-src-mode

2009-09-05 Thread Dan Davison
Carsten Dominik writes: > Hi Dan, > > OK, I have now applied the patch. If you don't mind, could > you please double-check the commit? [Re.: commit 4b6988bf36cb458c9d113ee4332e016990c1eb04 ] Thanks Carsten, I looked over the commit and it looked good. However after using it a bit over the last

Re: [Orgmode] Re: PATCH: proposed improvements to org-src-mode

2009-08-28 Thread Carsten Dominik
Hi Dan, OK, I have now applied the patch. If you don't mind, could you please double-check the commit? Thanks. - Carsten On Aug 28, 2009, at 4:36 AM, Dan Davison wrote: Carsten Dominik writes: Hi Dan, I am now finally looking at your patch. A few questions: On Aug 19, 2009, at 1:03 PM

Re: [Orgmode] Re: PATCH: proposed improvements to org-src-mode

2009-08-27 Thread Dan Davison
Carsten Dominik writes: > Hi Dan, > > I am now finally looking at your patch. > > A few questions: > > On Aug 19, 2009, at 1:03 PM, Dan Davison wrote: > >> Dan Davison writes: >> >>> Carsten Dominik writes: >>> Hi Dan, thank you for studying and describing these issues, and for >

Re: [Orgmode] Re: PATCH: proposed improvements to org-src-mode

2009-08-24 Thread Carsten Dominik
Hi Dan, I am now finally looking at your patch. A few questions: On Aug 19, 2009, at 1:03 PM, Dan Davison wrote: Dan Davison writes: Carsten Dominik writes: Hi Dan, thank you for studying and describing these issues, and for proposing a patch. I have noticed a bug in the patch I p

Re: [Orgmode] Re: PATCH: proposed improvements to org-src-mode

2009-08-19 Thread Dan Davison
Dan Davison writes: > Carsten Dominik writes: > >> Hi Dan, >> >> thank you for studying and describing these issues, and for proposing >> a patch. I have noticed a bug in the patch I proposed: the configuration of the edit buffer for saving must be done only after C-c ', and not for example whe

Re: [Orgmode] Re: PATCH: proposed improvements to org-src-mode

2009-08-12 Thread Dan Davison
Carsten Dominik writes: > Hi Dan, > > thank you for studying and describing these issues, and for proposing > a patch. > > I am not sure that the implementation you offer is the cleanest > possibile, I definitely do not want to attach a file to this temporary > editing buffer. Just to be clear,

[Orgmode] Re: PATCH: proposed improvements to org-src-mode

2009-08-12 Thread Carsten Dominik
Hi Dan, thank you for studying and describing these issues, and for proposing a patch. I am not sure that the implementation you offer is the cleanest possibile, I definitely do not want to attach a file to this temporary editing buffer. It is probably better to install a kill-buffer-hook to