Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Eric Schulte
Carsten Dominik writes: [...] > > The reason why this fails seems to be because of the looking-at. > When this code was first written, (match-beginning 0) referred to > the earlier regexp match, but the looking-at, if it matches, > changes the meaning of that form. > > Could you please try if my

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Carsten Dominik
Hi Eric, On Jun 28, 2010, at 9:59 PM, Eric Schulte wrote: Carsten Dominik writes: [...] For now I don't see anything wrong with this. The fastest way to find out is to put it into master and watch the list :-) Please go ahead and do that. I think this patch may have uncovered a bug in t

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Eric Schulte
Carsten Dominik writes: [...] > > For now I don't see anything wrong with this. The fastest > way to find out is to put it into master and watch the list :-) > Please go ahead and do that. > I think this patch may have uncovered a bug in the export preprocessing which was previously being cover

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Eric Schulte
Carsten Dominik writes: [...] > > For now I don't see anything wrong with this. The fastest > way to find out is to put it into master and watch the list :-) > Please go ahead and do that. > Great, I'll go ahead and try this. Thanks -- Eric ___ Emacs

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Carsten Dominik
On Jun 28, 2010, at 5:04 PM, Eric Schulte wrote: Hi Carsten, Carsten Dominik writes: [...] The above patch looks definitely right to me. In fact, I think the org-if-unprotected should be around the entire content of the while loop - with an additional fix to make sure search is resumed no

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Nicolas Goaziou
> Eric Schulte writes: > I would disagree here. There *is* a case where a protected comment > should be retained in the export. For example, if I'm writing a > document in which I want to discuss Org-mode markup. It should be > possible for me to include verbatim Org-mode code in my document

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Eric Schulte
Hi Nicolas, Nicolas Goaziou writes: > Hello, > >> Carsten Dominik writes: > >> The above patch looks definitely right to me. In fact, I think the >> org-if-unprotected should be around the entire content of the while >> loop - with an additional fix to make sure search is resumed not >> fro

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Nicolas Goaziou
Hello, > Carsten Dominik writes: > The above patch looks definitely right to me. In fact, I think the > org-if-unprotected should be around the entire content of the while > loop - with an additional fix to make sure search is resumed not > from the beginning of location of a match that has

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Eric Schulte
Hi Carsten, Carsten Dominik writes: [...] > > The above patch looks definitely right to me. In fact, I think the > org-if-unprotected should be around the entire content of the while > loop - with an additional fix to make sure search is resumed not > from the beginning of location of a match t

Re: [Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-28 Thread Carsten Dominik
Hi Eric, On Jun 28, 2010, at 4:42 AM, Eric Schulte wrote: I've put together two patches which fix the problems I mention below. I'd like to apply these patches, but I fear that they may cause unanticipated export problems. I'd be much more comfortable if someone who knows a little more abou

[Orgmode] Re: [BUG] nested blocks aren't protected on export

2010-06-27 Thread Eric Schulte
I've put together two patches which fix the problems I mention below. I'd like to apply these patches, but I fear that they may cause unanticipated export problems. I'd be much more comfortable if someone who knows a little more about the exporters could take a look at these. Thanks -- Eric >Fr