Re: [O] orgstruct-mode with custom headline prefix

2013-02-26 Thread Stephen Eglen
> Yes, you can send attachments to the list -- in general, please share > bugs publicly as much as possible, receiving private emails about bugs > is not encouraging for the maintainer (in this case Christopher) and > not useful for the other people on this list, as they cannot contribute > to deb

Re: [O] orgstruct-mode with custom headline prefix

2013-02-26 Thread Christopher Schmidt
Stephen Eglen writes: > Thanks Bastien for the explanation. I can now get support for > orgstruct without setting outline-regexp, but in so doing I found an > odd error. I've sent Christopher a minimal example, but didn't send > it to the list as I wasn't sure about whether attachments could be

Re: [O] orgstruct-mode with custom headline prefix

2013-02-26 Thread Bastien
Stephen Eglen writes: > Thanks Bastien for the explanation. I can now get support for orgstruct > without setting outline-regexp, but in so doing I found an odd error. > I've sent Christopher a minimal example, but didn't send it to the list > as I wasn't sure about whether attachments could be

Re: [O] orgstruct-mode with custom headline prefix

2013-02-26 Thread Stephen Eglen
> > No, it is not. Thanks Bastien for the explanation. I can now get support for orgstruct without setting outline-regexp, but in so doing I found an odd error. I've sent Christopher a minimal example, but didn't send it to the list as I wasn't sure about whether attachments could be sent to the

Re: [O] orgstruct-mode with custom headline prefix

2013-02-22 Thread Bastien
Hi Stephen, Dr Stephen J Eglen writes: > I just wanted to check though whether we need to set outline-regexp; No, it is not. > I think this part of `org-cycle' requires outline-regexp to be set, > but I just wanted to check whether this was a pre-requisite, as it > then seems that we are sett

Re: [O] orgstruct-mode with custom headline prefix

2013-02-19 Thread Dr Stephen J Eglen
Christopher Schmidt ch.ristopher.com> writes: > > Christopher Schmidt ch.ristopher.com> writes: > > I will push a fix ASAP. > > I did that now. > > d6f69f5 org.el: Use let instead of progv in org-run-like-in-org-mode > ea2d107 org.el: Declare orgstruct-mode > > Christopher >

Re: [O] orgstruct-mode with custom headline prefix

2013-02-13 Thread Achim Gratz
Christopher Schmidt writes: > I did that now. > > d6f69f5 org.el: Use let instead of progv in org-run-like-in-org-mode > ea2d107 org.el: Declare orgstruct-mode Thanks for fixing this. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation

Re: [O] orgstruct-mode with custom headline prefix

2013-02-13 Thread Sebastien Vauban
Hi Christopher and Bastien, Christopher Schmidt wrote: > Christopher Schmidt writes: >> I will push a fix ASAP. > > I did that now. > > d6f69f5 org.el: Use let instead of progv in org-run-like-in-org-mode > ea2d107 org.el: Declare orgstruct-mode FYI, I still have the reported problem whe

Re: [O] orgstruct-mode with custom headline prefix

2013-02-13 Thread Christopher Schmidt
Christopher Schmidt writes: > I will push a fix ASAP. I did that now. d6f69f5 org.el: Use let instead of progv in org-run-like-in-org-mode ea2d107 org.el: Declare orgstruct-mode Christopher

Re: [O] orgstruct-mode with custom headline prefix

2013-02-12 Thread Bastien
Hi Christopher, Christopher Schmidt writes: > These internal functions should have been autoloaded. progv is pretty > obscure and I guess noone has noticed that bug in cl-macs until now. The attached patch gets rid of progv by using org-let. As a side-effect, it fixes a but that was introduce

Re: [O] orgstruct-mode with custom headline prefix

2013-02-12 Thread Christopher Schmidt
Achim Gratz writes: > This introduces the following failures in compilation with Emacs 24.2 > and has a high chance of not working at all in some setups: > --8<---cut here---start->8--- > Compiling /home/gratz/lisp/org-mode/lisp/org.el... > > In org-heading-comp

Re: [O] orgstruct-mode with custom headline prefix

2013-02-12 Thread Achim Gratz
Christopher Schmidt writes: > This is in master now. The commit is a3f6570. This introduces the following failures in compilation with Emacs 24.2 and has a high chance of not working at all in some setups: --8<---cut here---start->8--- Compiling /home/gratz/li

Re: [O] orgstruct-mode with custom headline prefix

2013-02-11 Thread Bastien
Christopher Schmidt writes: > Christopher Schmidt writes: >> Here is the patch. Now one just needs >> >> ;; Local Variables: >> ;; eval: (orgstruct-mode 1) >> ;; orgstruct-heading-prefix-regexp: ";;; " >> ;; End: > > This is in master now. The commit is a3f6570. Thanks a lot!

Re: [O] orgstruct-mode with custom headline prefix

2013-02-10 Thread Christopher Schmidt
Christopher Schmidt writes: > Here is the patch. Now one just needs > > ;; Local Variables: > ;; eval: (orgstruct-mode 1) > ;; orgstruct-heading-prefix-regexp: ";;; " > ;; End: This is in master now. The commit is a3f6570. Christopher

Re: [O] orgstruct-mode with custom headline prefix

2013-02-01 Thread Carsten Dominik
Hi Christopher, I have trouble applying it, can you please send the patch as an attachments instead of inline, and make sure it is agains the current master? Thanks. - Carsten On 31 jan. 2013, at 21:06, Christopher Schmidt wrote: > Bastien writes: >> PS: To make things clear: I'm confident

Re: [O] orgstruct-mode with custom headline prefix

2013-01-31 Thread Thorsten Jolitz
Christopher Schmidt writes: > Here is the patch. Now one just needs > > ;; Local Variables: > ;; eval: (orgstruct-mode 1) > ;; orgstruct-heading-prefix-regexp: ";;; " > ;; End: > > It cannot get any easier than this. Just a question - why ";;; " and not ";; " (i.e. ";; \*+ ")?

Re: [O] orgstruct-mode with custom headline prefix

2013-01-31 Thread Christopher Schmidt
Christopher Schmidt writes: This is the memory profiler result. > a2febd210182d9e1a37b0d7fd9ee007a10abc4bc refs/remotes/origin/HEAD > Saved working directory and index state WIP on master: a2febd2 Merge > branch 'maint' > HEAD is now at a2febd2 Merge branch 'maint' > OVERVIEW >

Re: [O] orgstruct-mode with custom headline prefix

2013-01-31 Thread Christopher Schmidt
Bastien writes: > PS: To make things clear: I'm confident the patch is good, but I will > put it higher on my patch review process if I know the agenda does not > slow down :) Here is the patch. Now one just needs ;; Local Variables: ;; eval: (orgstruct-mode 1) ;; orgstruct-heading-

Re: [O] orgstruct-mode with custom headline prefix (was: ...)

2013-01-31 Thread Christopher Schmidt
Carsten Dominik writes: > I was just thinking, if you are setting up two local variables, you > could set up three and include org-outline-regexp-bol as well. Or, > you could just set up org-outline-regexp', and make the function > org-struct-mode set up the other two as additional local variable

Re: [O] orgstruct-mode with custom headline prefix

2013-01-31 Thread Bastien
Hi Christopher, Christopher Schmidt writes: > All my agendas generate just fine. I am not exactly sure how I can > provide figures and tests. You can instrument org with M-x elp-instrument-package RET org RET then check the results (after running an agenda command) with M-x elp-results RET Y

Re: [O] orgstruct-mode with custom headline prefix

2013-01-31 Thread Christopher Schmidt
Bastien writes: Hi Bastien, >> Bastien writes: >>> Can you give an indication on how it impacts the generation of >>> agenda? This is a potential blocker. >> >> It should not impact agenda generation at all - neither feature nor >> performance-wise. All non-trivial changes are in parts of the

Re: [O] orgstruct-mode with custom headline prefix

2013-01-31 Thread Bastien
Hi Christopher, Christopher Schmidt writes: > Bastien writes: >> Can you give an indication on how it impacts the generation of agenda? >> This is a potential blocker. > > It should not impact agenda generation at all - neither feature nor > performance-wise. All non-trivial changes are in par

Re: [O] orgstruct-mode with custom headline prefix

2013-01-31 Thread Christopher Schmidt
Bastien writes: > Can you give an indication on how it impacts the generation of agenda? > This is a potential blocker. It should not impact agenda generation at all - neither feature nor performance-wise. All non-trivial changes are in parts of the code that directly relate to orgstruct-mode or

Re: [O] orgstruct-mode with custom headline prefix

2013-01-30 Thread Bastien
Hi Christopher, Christopher Schmidt writes: > Here is the patch, now applying cleanly on master again. I did not have time to try the patch yet. Can you give an indication on how it impacts the generation of agenda? This is a potential blocker. Also, we won't be able to apply such a change u

Re: [O] orgstruct-mode with custom headline prefix

2013-01-30 Thread Christopher Schmidt
Christopher Schmidt writes: > here is a patch for master that enables the use of a custom headline > prefix file locally in conjunction with orgstruct-mode. Here is the patch, now applying cleanly on master again. --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4437,9 +4437,9 @@ in `org-age

[O] orgstruct-mode with custom headline prefix

2013-01-28 Thread Christopher Schmidt
Hi Org, here is a patch for master that enables the use of a custom headline prefix file locally in conjunction with orgstruct-mode. 2013-01-28 Christopher Schmidt * org.el (org-outline-regexp, org-heading-regexp): Make them safe local variables. (org-o