Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-23 Thread Stefan Monnier
>>> The first is whether orgalist-mode couldn't use a custom >>> indent-line-function instead of advising what may or may not be set to >>> indent-relative by the user. >> I don't know how that would work in practice. > Me neither. >> But a minor mode taking control over `indent-line-function' soun

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-23 Thread Basil L. Contovounesios
Nicolas Goaziou writes: > "Basil L. Contovounesios" writes: > >> The first is whether orgalist-mode couldn't use a custom >> indent-line-function instead of advising what may or may not be set to >> indent-relative by the user. > > I don't know how that would work in practice. Me neither. > Bu

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-23 Thread Nicolas Goaziou
Hello, "Basil L. Contovounesios" writes: > The first is whether orgalist-mode couldn't use a custom > indent-line-function instead of advising what may or may not be set to > indent-relative by the user. I don't know how that would work in practice. But a minor mode taking control over `indent-

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-12 Thread Amin Bandali
Hi all, Just confirming that I suffer from this as well on latest master. It’d be great if this could be fixed. Cheers, amin

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-11 Thread Stefan Monnier
> The third is why indent-according-to-mode hard-codes the check for > indent-relative and indent-relative-first-indent-point. Wouldn't it be > nice if this check instead looked up some variable akin to > electric-indent-functions-without-reindent, that can be more easily > customised? Agreed. C

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-02 Thread Stefan Monnier
> Now that add-function sets indent-line-function to a custom closure, > however, (advice--cd*r indent-line-function) no longer returns > indent-relative and the workaround breaks. I think this qualifies as a problem in nadvice: the ad-hoc closure introduced to "redirect to the default-value" shou

Re: [O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-01 Thread Basil L. Contovounesios
[CCing Stefan as the nadvice.el expert.] Gregor Zattler writes: > Dear org-mode developers, hello Nicolas, > I use orgalist-mode while writing emails in > notmuch-message-mode. Today I updated emacs (from git), and > since then, the second line of a paragraph get's indented >

[O] orgalist-mode: wrong indentation in message mode after recent change in emacs

2019-04-01 Thread Gregor Zattler
Dear org-mode developers, hello Nicolas, I use orgalist-mode while writing emails in notmuch-message-mode. Today I updated emacs (from git), and since then, the second line of a paragraph get's indented (and succeeding lines too). As demonstrated with this email. While I writ