Re: [O] org-timer-set-timer org-notify message and sound arguments

2013-09-16 Thread Bastien
Hi Devin, Devin Homan writes: > Here is a `git diff -p org-timer.el' of the changes that I am > proposing. sorry, I made a change earlier that makes this patch non-applicable. This does not mean I'm against the change you propose, I just overlooked it. Don't hesitate to rework the patch and gi

Re: [O] org-timer-set-timer org-notify message and sound arguments

2013-09-03 Thread Devin Homan
Here is a `git diff -p org-timer.el' of the changes that I am proposing. diff --git a/lisp/org-timer.el b/lisp/org-timer.el index 2351c4c..cb0ce45 100644 --- a/lisp/org-timer.el +++ b/lisp/org-timer.el @@ -93,6 +93,25 @@ nil current timer is not displayed" (defvar org-timer-cancel-hook n

[O] org-timer-set-timer org-notify message and sound arguments

2013-09-03 Thread Devin Homan
The current implementation of org-timer-set-timer calls org-notify with the PLAY-SOUND argument set to 't', which gets passed to org-clock-play-sound that then in turn calls the beep function. The value of this argument should be defined in a defvar so as to allow the user to modify or dynamically