Re: [O] ob-clojure.el alternative using nrepl

2013-10-04 Thread Eric Schulte
Oleh writes: > Thanks, Eric. > > Your changes work. > Great, thanks for the patch. > > Still, I think that it's needed to require ob-tangle. > It defines the variable `org-babel-tangle-lang-exts' that ob-clojure > wants to modify right at loading. So it's impossible to load ob-clojure > unless

Re: [O] ob-clojure.el alternative using nrepl

2013-10-04 Thread Oleh
Thanks, Eric. Your changes work. Still, I think that it's needed to require ob-tangle. It defines the variable `org-babel-tangle-lang-exts' that ob-clojure wants to modify right at loading. So it's impossible to load ob-clojure unless ob-tangle was already loaded. Just to clarify, this code will

Re: [O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Eric Schulte
Bastien writes: > Hi Eric, > > Eric Schulte writes: > >> Please try out the attached patch which may be applied overtop of your >> patch and let me know if it works? I had to guess at the two nrepl >> function arguments. > > It works fine for nrepl.el, thanks a lot! Alright, I just pushed this

Re: [O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Bastien
Hi Eric, Eric Schulte writes: > Please try out the attached patch which may be applied overtop of your > patch and let me know if it works? I had to guess at the two nrepl > function arguments. It works fine for nrepl.el, thanks a lot! -- Bastien

Re: [O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Eric Schulte
Oleh writes: > Hi Eric, > > I can make the changes tomorrow. > Or you can make them now if you like. Please try out the attached patch which may be applied overtop of your patch and let me know if it works? I had to guess at the two nrepl function arguments. >From ee6c792ec7657e50524d78d309538

Re: [O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Oleh
Hi Eric, I can make the changes tomorrow. Or you can make them now if you like. I required ob-tangle because it's a pre-requisite for ob-clojure: an error is thrown if I try to load ob-clojure before ob-tangle. So it makes sense to me to require it. regards, Oleh On Thu, Oct 3, 2013 at 8:06 PM,

Re: [O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Eric Schulte
Thanks for this update. Oleh writes: > Here's an updated patch. > I use defalias, is that OK? > Two changes. 1. instead of customization through a defalias, use defcustom and a variable which determines which function (eval-slime or eval-nrepl) is called. 2. ob-*.el files should not req

Re: [O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Oleh
Here's an updated patch. I use defalias, is that OK? Oleh On Thu, Oct 3, 2013 at 6:23 PM, Bastien wrote: > Hi Oleh, > > Oleh writes: > > > Should I rather put the code in ob-clojure.el with something like > > (defcustom ob-clojure-method nrepl)? > > Yes, I think it's better. Maybe > > (defcu

Re: [O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Bastien
Hi Oleh, Oleh writes: > Current method of clojure evaluation is through slime. > I couldn't get it to work, when I tried long ago. > So I attach one that uses nrepl. > Switching between the two should be as easy as using > > (require 'ob-clojure) > or > (require 'ob-clojure-nrepl). Nice, someth

Re: [O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Oleh
I guess that I forgot the attachment. Oleh On Thu, Oct 3, 2013 at 5:45 PM, Oleh wrote: > Hi all, > > Current method of clojure evaluation is through slime. > I couldn't get it to work, when I tried long ago. > So I attach one that uses nrepl. > Switching between the two should be as easy as us

[O] ob-clojure.el alternative using nrepl

2013-10-03 Thread Oleh
Hi all, Current method of clojure evaluation is through slime. I couldn't get it to work, when I tried long ago. So I attach one that uses nrepl. Switching between the two should be as easy as using (require 'ob-clojure) or (require 'ob-clojure-nrepl). regards, Oleh