Re: [O] a patch to ob-lisp.el

Hello, "numbch...@gmail.com" writes: > Oh, right. I should attach it. Applied, with a few fixes. Thank you. Regards, -- Nicolas Goaziou

Re: [O] a patch to ob-lisp.el

Oh, right. I should attach it. ```diff >From 30eec5a63e4f720fa3880b9aef06aedd84072078 Mon Sep 17 00:00:00 2001 From: stardiviner Date: Sat, 2 Apr 2016 00:46:36 +0800 Subject: [PATCH] add SLY support in ob-lisp * ob-lisp.el (org-babel-execute:lisp): Support using SLY to evaluate lisp src block.

Re: [O] a patch to ob-lisp.el

Hello, "numbch...@gmail.com" writes: > Hi, Nicolas, the another email which you commented many places is outdated. > That patch is modified from the version of MELPA package `org-plus-conrtib`. > > I cloned org-mode git repo, and created public repo branch at here: > https://github.com/stardivin

Re: [O] a patch to ob-lisp.el

Hi, Nicolas, the another email which you commented many places is outdated. That patch is modified from the version of MELPA package `org-plus-conrtib`. I cloned org-mode git repo, and created public repo branch at here: https://github.com/stardiviner/org-mode/tree/sly-support-for-ob-lisp I check

Re: [O] a patch to ob-lisp.el

Hello, "numbch...@gmail.com" writes: > Ask a beside question. I cloned org-mode git repo, should I contribute my > patch with git way? (I mean create a git branch on my own public clone, > then paste it here to let maintainer merge it?) Please look at the document suggested by Thomas. In partic

Re: [O] a patch to ob-lisp.el

Hello, "numbch...@gmail.com" writes: > My think my patch modifies less than 15 lines. Do I have to assign the > copyright of FSF? No you don't. That will be helpful for your next patches. > I have sent one. But no response for some days. I hope Org-mode maintainer > can merge this patch. The

Re: [O] a patch to ob-lisp.el

Ask a beside question. I cloned org-mode git repo, should I contribute my patch with git way? (I mean create a git branch on my own public clone, then paste it here to let maintainer merge it?) [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitt

Re: [O] a patch to ob-lisp.el

My think my patch modifies less than 15 lines. Do I have to assign the copyright of FSF? I have sent one. But no response for some days. I hope Org-mode maintainer can merge this patch. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @nu

Re: [O] a patch to ob-lisp.el

Aloha stardiviner, For instructions about the FSF papers, see http://orgmode.org/worg/org-contribute.html. All the best, Tom numbch...@gmail.com writes: > I updated all comments which you point out. > I wandering how to sign the FSF papers? Sorry about this, this is my first > time > to contri

Re: [O] a patch to ob-lisp.el

I updated all comments which you point out. I wandering how to sign the FSF papers? Sorry about this, this is my first time to contribute code in open source. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint =

Re: [O] a patch to ob-lisp.el

stardiviner writes: > I hope to merge this patch to Org-mode `ob-lisp.el`. > I have only looked at the surface of it, but I see some issues. > < ;; Copyright (C) 2016-2020 Free Software Foundation, Inc. > --- > > ;; Copyright (C) 2009-2016 Free Software Foundation, Inc. Why did you leave out t

[O] a patch to ob-lisp.el

Here is my repo, and I also created an recipe on MELPA. - http://gituhb.com/stardiviner/ob-lisp - https://github.com/melpa/melpa/pull/3682 I hope to merge this patch to Org-mode `ob-lisp.el`. 1c1 < ;;; ob-lisp.el --- org-babel functions for common lisp evaluation with SLY or SLIME. --- > ;;; ob