Nicolas Goaziou writes:
> As a first approximation, I think
>
> (with-current-buffer (marker-buffer org-log-note-marker)
> (goto-char org-log-note-marker)
> (copy-marker (org-log-beginning)))
>
> is close to what `org-log-note-marker' used to be.
Thanks for the code example - I used i
Kaushal Modi writes:
Hi Kaushal,
> Recently the global variable org-log-note-marker was removed from
> org.el.
>
> But it is used in outshine.el as follows:
>
> (defadvice org-store-log-note (around org-store-log-note-around
> activate)
> "Outcomment inserted log-note in Outshine buffers."
> (le
Hello,
Nicolas Richard writes:
> Did you consider renaming it, in the case some code relies on it ?
I don't consider it worth the hassle to rename internal variables
whenever we change their value.
>> (with-current-buffer (marker-buffer org-log-note-marker)
>> (goto-char (org-log-note-ma
Nicolas Goaziou writes:
> Actually, it was a mistake to remove the variable in the first place. As
> a consequence, I re-introduced it in master.
>
> However, it doesn't store the same location as before, i.e., it merely
> points to the entry where the note is going to be added instead of the
> ac
> Actually, it was a mistake to remove the variable in the first place. As
> a consequence, I re-introduced it in master.
Thanks. That has fixed the free variable warning.
@Thorsten But now you might need to have different versions of defadvice
for org-store-log-note based on the value of org-ver
Hello,
Kaushal Modi writes:
>> Was it just removed, or rather renamed or replaced by something else?
>> Maybe the fix would be trivial if somebody with insights about the
>> change could give some hints?
>
> I have never needed to use this function, so I cannot comment on it. So
> asking Nicolas
> Was it just removed, or rather renamed or replaced by something else?
> Maybe the fix would be trivial if somebody with insights about the
> change could give some hints?
I have never needed to use this function, so I cannot comment on it. So
asking Nicolas for help regarding this.
> Recently I
Hi Thorsten,
Recently the global variable org-log-note-marker was removed from org.el.
But it is used in outshine.el as follows:
(defadvice org-store-log-note (around org-store-log-note-around activate)
"Outcomment inserted log-note in Outshine buffers."
(let ((outshine-log-note-beg-marker
;
