Re: [O] Unclear org-icompleting-read interface

2015-06-25 Thread Rasmus
Hi, Nicolas Goaziou writes: > Rasmus writes: > >> I agree. It's confusing how the docstring and the λ is written, but it's >> just a "front-end" for completing-read. A reference to completing-read >> should be added to the docstring. > > Isn't it already the case? I don't know. I have been

Re: [O] Unclear org-icompleting-read interface

2015-06-25 Thread Nicolas Goaziou
Hello, Rasmus writes: > I agree. It's confusing how the docstring and the λ is written, but it's > just a "front-end" for completing-read. A reference to completing-read > should be added to the docstring. Isn't it already the case? > That was my "feeling" about org-icompleting-read as well

Re: [O] Unclear org-icompleting-read interface

2015-06-25 Thread Rasmus
Hi, Nicolas Goaziou writes: > Oleh Krehel writes: > >> The current `org-icompleting-read' is defined as taking only `&rest >> args', which can be as many as 8, all of them without a name. >> >> I propose to update the definition to: >> >> (cl-defun org-icompleting-read (prompt collection >>

Re: [O] Unclear org-icompleting-read interface

2015-06-25 Thread Oleh Krehel
Nicolas Goaziou writes: > Moreover, > `org-icompleting-read' is not harder to read as `completing-read' > anyway. I disagree on this. `completing-read' at least declares its own argument list. So it's possible to distinguish which argument is which, albeit with some effort for a large amount of

Re: [O] Unclear org-icompleting-read interface

2015-06-25 Thread Nicolas Goaziou
Hello, Oleh Krehel writes: > The current `org-icompleting-read' is defined as taking only `&rest > args', which can be as many as 8, all of them without a name. > > I propose to update the definition to: > > (cl-defun org-icompleting-read (prompt collection >

[O] Unclear org-icompleting-read interface

2015-06-25 Thread Oleh Krehel
Hi all, The current `org-icompleting-read' is defined as taking only `&rest args', which can be as many as 8, all of them without a name. I propose to update the definition to: (cl-defun org-icompleting-read (prompt collection &key predicate require-match