Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-14 Thread Carsten Dominik
This looks great. Can you now make a single patch for all the changes? Then I will apply it. - Carsten On 14 mei 2013, at 08:18, Daniil Frumin wrote: > OK, here's a patch which adds the ability to highlight the selected text. > > It makes new highlight notes only if `org-mac-Skim-highlight-s

Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-13 Thread Daniil Frumin
OK, here's a patch which adds the ability to highlight the selected text. It makes new highlight notes only if `org-mac-Skim-highlight-selection-p' is set to t. - Dan 0004-Add-the-ability-to-highlight-the-selected-text-in-Sk.patch Description: Binary data On May 14, 2013, at 8:33 AM, Carste

Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-13 Thread Carsten Dominik
On 13.5.2013, at 22:35, Daniil Frumin wrote: > So I've been researching this problem and it seems that there is no sane way > to re-select a text. OK, thanks for looking into it. > > The problem is that `(do-applescript ..)' only interacts with AppleScript > well if the return type of the

Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-13 Thread Daniil Frumin
So I've been researching this problem and it seems that there is no sane way to re-select a text. The problem is that `(do-applescript ..)' only interacts with AppleScript well if the return type of the string is either a number or a string. If I try to convert the selection object (which is n

Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-13 Thread Carsten Dominik
On 13 mei 2013, at 11:53, Daniel F wrote: > Hi Carsten, Ivan. > > Thanks for the feedback. The issue that Ivan mentioned does look important > and I'll try to fix it asap and incorporate the check. > I'll also look into the rehilighting thing, I am not sure if that's possible. > I guess it al

Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-13 Thread Daniel F
Hi Carsten, Ivan. Thanks for the feedback. The issue that Ivan mentioned does look important and I'll try to fix it asap and incorporate the check. I'll also look into the rehilighting thing, I am not sure if that's possible. I guess it also would be nice to scroll not just to the right page, but

Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-12 Thread Carsten Dominik
Hi Daniil, I like this a lot and would like to take the patch after you have taken Ivans feedback, and maybe more feedback if you get any. I would like it even more if following the link would rehighlight the selected text. Is there any way to achieve this? I have another question, this would

Re: [O] Skim.app support for org-mac-link-grabber.el

2013-05-12 Thread Ivan Andrus
Just two comments from someone who didn't know org-mac-link-grabber existed until today (I'm gonna try it out) and hasn't (yet) contributed to org-mode. 1. It looks like it's actually enabled by default 2. You can detect whether it should be enabled by default with something like (< 0 (length (s

[O] Skim.app support for org-mac-link-grabber.el

2013-05-12 Thread Daniil Frumin
Hi, all! I use org-mac-link-grabber.el almost every day. However, it lacks support for an app that I'd like to use together with org-mode. Skim.app is a light and fast PDF reader for Mac OS X with a note-taking ability. I wrote